Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve network error handling #5036

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Feature/improve network error handling #5036

merged 6 commits into from
Jun 28, 2023

Conversation

mgallien
Copy link
Collaborator

No description provided.

allexzander
allexzander reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@allexzander allexzander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgallien Please fix compile errors, and see my comments (nitpicks mostly). Also, I have noticed tests are failing.

@mgallien mgallien force-pushed the feature/improveNetworkErrorHandling branch 3 times, most recently from e8b0e57 to a04a4f2 Compare October 17, 2022 14:24
@mgallien mgallien force-pushed the feature/improveNetworkErrorHandling branch from 8fdaac6 to ca3ecab Compare October 18, 2022 07:36
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 23 Code Smells

33.2% 33.2% Coverage
0.0% 0.0% Duplication

@tobiasKaminsky tobiasKaminsky linked an issue Oct 26, 2022 that may be closed by this pull request
[Bug]: Better handle network errors #4955
Closed
8 tasks
@allexzander
Copy link
Contributor

@matthieugallien Added just one more comment, but more of a nitpick. Kindly do not forget to clean-up the history.

@allexzander allexzander self-requested a review October 29, 2022 10:45
@mgallien mgallien force-pushed the feature/improveNetworkErrorHandling branch from ca3ecab to f9bdc27 Compare November 22, 2022 09:51
@mgallien mgallien force-pushed the feature/improveNetworkErrorHandling branch 4 times, most recently from 9ac1538 to e64bf60 Compare January 26, 2023 20:12
@mgallien mgallien force-pushed the feature/improveNetworkErrorHandling branch 2 times, most recently from ab981a7 to fde011c Compare February 2, 2023 08:51
@codecov
Copy link

codecov bot commented Feb 2, 2023 •
edited
Loading

Codecov Report

Merging #5036 (9cab7b5) into master (a7e10a1) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 9cab7b5 differs from pull request most recent head 033a37e. Consider uploading reports for the commit 033a37e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5036      +/-   ##
==========================================
+ Coverage   60.40%   60.42%   +0.01%     
==========================================
  Files         145      145              
  Lines       18617    18617              
==========================================
+ Hits        11246    11249       +3     
+ Misses       7371     7368       -3
Impacted Files Coverage Δ
src/libsync/propagateupload.cpp 75.54% <ø> (ø)
src/libsync/propagateupload.h 44.64% <ø> (ø)

... and 1 file with indirect coverage changes

@mgallien mgallien force-pushed the feature/improveNetworkErrorHandling branch from fde011c to 8aa2390 Compare February 3, 2023 11:21
@mgallien mgallien force-pushed the feature/improveNetworkErrorHandling branch 2 times, most recently from 1e7af34 to 85c850b Compare February 23, 2023 12:18
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 21 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@mgallien mgallien force-pushed the feature/improveNetworkErrorHandling branch 2 times, most recently from e9cab4b to 4fbb6df Compare June 8, 2023 15:40
@mgallien mgallien force-pushed the feature/improveNetworkErrorHandling branch from 4fbb6df to 9cab7b5 Compare June 26, 2023 09:24
@mgallien
fix ignored signals due to using old connect syntax
69d2b06 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
declare state property in AccountState
8cf778b 
should make it more logic to find the property when needed

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
ActivityListModel now keeps track of the account connection state
431ccfe 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
add more metadata to sync errors to allow filtering
0e002f3 
in order to be able to filter some errors when showing them into the
main dialog activity list, add some more info about the error to know
the origin (like a network issue or a sync issue)

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
filter out some errors if they are related to network troubles
cd6ee68 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
remove wrong code
033a37e 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the feature/improveNetworkErrorHandling branch from 9cab7b5 to 033a37e Compare June 28, 2023 09:21
@mgallien mgallien enabled auto-merge June 28, 2023 09:22
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5036-033a37e7d1419ffe569c15fa58c122618cceb465-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

41.4% 41.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mgallien mgallien merged commit 0a65df1 into master Jun 28, 2023
@mgallien mgallien deleted the feature/improveNetworkErrorHandling branch June 28, 2023 10:05
@mgallien mgallien added this to the 3.10.0 milestone Jul 4, 2023
@Mika-6-9 Mika-6-9 mentioned this pull request Feb 22, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan Awaiting requested review from camilasan

@claucambra claucambra Awaiting requested review from claucambra

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Better handle network errors
3 participants
@mgallien @allexzander @nextcloud-desktop-bot