Skip to content

Commit

Permalink
Fix clang-tidy errors.
Browse files Browse the repository at this point in the history
Signed-off-by: alex-z <[email protected]>
  • Loading branch information
allexzander committed Nov 28, 2023
1 parent a64fc87 commit 95b2abf
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/libsync/clientstatusreporting.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
#include <QTimer>
#include <QtSql>

class TestClientStatusReporting;

namespace OCC {

Check warning on line 29 in src/libsync/clientstatusreporting.h

View workflow job for this annotation

GitHub Actions / build

/src/libsync/clientstatusreporting.h:29:11 [cppcoreguidelines-avoid-non-const-global-variables]

variable 'OCC' is non-const and globally accessible, consider making it const

class Account;
Expand Down Expand Up @@ -56,6 +54,8 @@ class OWNCLOUDSYNC_EXPORT ClientStatusReporting : public QObject
explicit ClientStatusReporting(Account *account, QObject *parent = nullptr);
~ClientStatusReporting();

static QByteArray statusStringFromNumber(const Status status);

private:
void init();
// reporting must happen via Account
Expand All @@ -80,15 +80,16 @@ private slots:
void sendReportToServer();

private:
static QByteArray statusStringFromNumber(const Status status);
static QByteArray classifyStatus(const Status status);

public:
static int clientStatusReportingTrySendTimerInterval;
static quint64 repordSendIntervalMs;

// this must be set in unit tests on init
static QString dbPathForTesting;

private:

Account *_account = nullptr;

QSqlDatabase _database;
Expand All @@ -103,6 +104,5 @@ private slots:
mutable QRecursiveMutex _mutex;

friend class Account;
friend class TestClientStatusReporting;
};
}

0 comments on commit 95b2abf

Please sign in to comment.