Skip to content

Commit

Permalink
Fix clang-tidy errors.
Browse files Browse the repository at this point in the history
Signed-off-by: alex-z <[email protected]>
  • Loading branch information
allexzander committed Nov 28, 2023
1 parent efb69a4 commit a64fc87
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/libsync/clientstatusreporting.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ namespace OCC
Q_LOGGING_CATEGORY(lcClientStatusReporting, "nextcloud.sync.clientstatusreporting", QtInfoMsg)

Check warning on line 30 in src/libsync/clientstatusreporting.cpp

View workflow job for this annotation

GitHub Actions / build

/src/libsync/clientstatusreporting.cpp:30:1 [cppcoreguidelines-avoid-non-const-global-variables]

variable 'Q_LOGGING_CATEGORY' is non-const and globally accessible, consider making it const

ClientStatusReporting::ClientStatusReporting(Account *account, QObject *parent)
: _account(account)
, QObject(parent)
: QObject(parent)
, _account(account)
{
init();
}
Expand Down Expand Up @@ -410,6 +410,6 @@ QByteArray ClientStatusReporting::classifyStatus(const Status status)
return {};
}
int ClientStatusReporting::clientStatusReportingTrySendTimerInterval = 1000 * 60 * 2; // check if the time has come, every 2 minutes
int ClientStatusReporting::repordSendIntervalMs = 24 * 60 * 60 * 1000; // once every 24 hours
quint64 ClientStatusReporting::repordSendIntervalMs = 24 * 60 * 60 * 1000; // once every 24 hours
QString ClientStatusReporting::dbPathForTesting;
}
2 changes: 1 addition & 1 deletion src/libsync/clientstatusreporting.h
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ private slots:
static QByteArray classifyStatus(const Status status);

static int clientStatusReportingTrySendTimerInterval;
static int repordSendIntervalMs;
static quint64 repordSendIntervalMs;

// this must be set in unit tests on init
static QString dbPathForTesting;
Expand Down

0 comments on commit a64fc87

Please sign in to comment.