Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code change for ion and ion style semantics. Unlimited numbers. #3097

Merged
merged 34 commits into from
Oct 25, 2024
Merged

Code change for ion and ion style semantics. Unlimited numbers. #3097

merged 34 commits into from
Oct 25, 2024

Commits on Aug 22, 2024

  1. increased maximum number of ions per compartment by using std::bitset… 

    … for bitvector comparisons
    @wthun
    wthun committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4232cab View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. changed vector.reserve to vector.resize to initialize std::bitset ele… 

    …ments
    @wthun
    wthun committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5179cc4 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @wthun
    wthun committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    61162e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge branch 'master' into hines/ions

    @nrnhines
    nrnhines committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    25fa1aa View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. test of high mechanism index ions and mechanisms

    @nrnhines
    nrnhines committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3c01089 View commit details
    Browse the repository at this point in the history

  2. Fix formatting

    @github-actions
    github-actions[bot] committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7ccc143 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge branch 'master' into master

    @1uc
    1uc authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fb2d01a View commit details
    Browse the repository at this point in the history

  2. rename max_length to max_ion 

    Co-authored-by: Luc Grosheintz <[email protected]>
    @wthun @1uc
    wthun and 1uc authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fc27477 View commit details
    Browse the repository at this point in the history

  3. Update src/nrnoc/eion.cpp 

    Co-authored-by: Luc Grosheintz <[email protected]>
    @wthun @1uc
    wthun and 1uc authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e36452c View commit details
    Browse the repository at this point in the history

  4. Update src/nrnoc/eion.cpp 

    Co-authored-by: Luc Grosheintz <[email protected]>
    @wthun @1uc
    wthun and 1uc authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3b5e359 View commit details
    Browse the repository at this point in the history

  5. Update src/nrnoc/eion.cpp 

    Co-authored-by: Luc Grosheintz <[email protected]>
    @wthun @1uc
    wthun and 1uc authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dc47da5 View commit details
    Browse the repository at this point in the history

  6. cmake-format

    @wthun
    wthun committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    570a9ae View commit details
    Browse the repository at this point in the history

  7. increased max_ion to 256

    @wthun
    wthun committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dc11e93 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'forked/master' into hines/ions

    @nrnhines
    nrnhines committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7293b78 View commit details
    Browse the repository at this point in the history

  9. Temporarily adjust test to create 250 ions.

    @nrnhines
    nrnhines committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3f5c418 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into hines/ions

    @nrnhines
    nrnhines authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    da974c2 View commit details
    Browse the repository at this point in the history

  11. Use generic mod file loader

    @nrnhines
    nrnhines committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3f213b0 View commit details
    Browse the repository at this point in the history

  12. ion_bit_ can have many bits.

    @nrnhines
    nrnhines committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    23071ee View commit details
    Browse the repository at this point in the history

  13. For bitset single bit, first reset, then set the bit.

    @nrnhines
    nrnhines committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6604aab View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Add another mod file to neurondemo that WRITE cai. More testing.

    @nrnhines
    nrnhines committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    0d087b7 View commit details
    Browse the repository at this point in the history

  2. eion.cpp -Wall free

    @nrnhines
    nrnhines committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    bfc82da View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. eion.cpp coverage 100% functions 94% lines

    @nrnhines
    nrnhines committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    ebf26b1 View commit details
    Browse the repository at this point in the history

  2. Replace // LCOV_EXCL_END with // LCOV_EXCL_STOP

    @nrnhines
    nrnhines committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    06f9ace View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. no limit on number of ion mechanisms

    @nrnhines
    nrnhines committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    aea6299 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Code change for ion and ion style semantics. Unlimited numbers.

    @nrnhines
    nrnhines committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    aceb0c5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into hines/ions

    @nrnhines
    nrnhines authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    74d6029 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Fix the CI test coverage failure.

    @nrnhines
    nrnhines committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1318a3f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'hines/ions' into hines/ions-unlimited

    @nrnhines
    nrnhines authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a9de3d7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'hines/ions-unlimited' into hines/ions-unlimited-semantics

    @nrnhines
    nrnhines authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    7223c0c View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'master' into hines/ions-unlimited-semantics

    @nrnhines
    nrnhines committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3e3358a View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Merge branch 'master' into hines/ions-unlimited-semantics

    @nrnhines
    nrnhines committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    4d1171a View commit details
    Browse the repository at this point in the history

  2. format

    @nrnhines
    nrnhines committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bc44c53 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. accept review suggestion

    @nrnhines
    nrnhines committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    afb072e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into hines/ions-unlimited-semantics

    @nrnhines
    nrnhines committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b6f9307 View commit details
    Browse the repository at this point in the history