Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code change for ion and ion style semantics. Unlimited numbers. #3097

Merged
merged 34 commits into from
Oct 25, 2024
Merged

Code change for ion and ion style semantics. Unlimited numbers. #3097

merged 34 commits into from
Oct 25, 2024

Conversation

nrnhines
Copy link
Member

@nrnhines nrnhines commented Sep 26, 2024 •
edited
Loading

Ion and ion style semantics code change allows max_int number/2 of ion types.

wthun and others added 26 commits August 22, 2024 14:41
@wthun
increased maximum number of ions per compartment by using std::bitset…
4232cab 
… for bitvector comparisons
@wthun
changed vector.reserve to vector.resize to initialize std::bitset ele…
5179cc4 
…ments
@wthun
cleanup
61162e4
@nrnhines
Merge branch 'master' into hines/ions
25fa1aa
@nrnhines
test of high mechanism index ions and mechanisms
3c01089
@github-actions
Fix formatting
7ccc143
@1uc
Merge branch 'master' into master
fb2d01a
@wthun @1uc
rename max_length to max_ion
fc27477 
Co-authored-by: Luc Grosheintz <[email protected]>
@wthun @1uc
Update src/nrnoc/eion.cpp
e36452c 
Co-authored-by: Luc Grosheintz <[email protected]>
@wthun @1uc
Update src/nrnoc/eion.cpp
3b5e359 
Co-authored-by: Luc Grosheintz <[email protected]>
@wthun @1uc
Update src/nrnoc/eion.cpp
dc47da5 
Co-authored-by: Luc Grosheintz <[email protected]>
@wthun
cmake-format
570a9ae
@wthun
increased max_ion to 256
dc11e93
@nrnhines
Merge remote-tracking branch 'forked/master' into hines/ions
7293b78
@nrnhines
Temporarily adjust test to create 250 ions.
3f5c418
@nrnhines
Merge branch 'master' into hines/ions
da974c2
@nrnhines
Use generic mod file loader
3f213b0
@nrnhines
ion_bit_ can have many bits.
23071ee
@nrnhines
For bitset single bit, first reset, then set the bit.
6604aab
@nrnhines
Add another mod file to neurondemo that WRITE cai. More testing.
0d087b7
@nrnhines
eion.cpp -Wall free
bfc82da
@nrnhines
eion.cpp coverage 100% functions 94% lines
ebf26b1
@nrnhines
Replace // LCOV_EXCL_END with // LCOV_EXCL_STOP
06f9ace
@nrnhines
no limit on number of ion mechanisms
aea6299
@nrnhines
Code change for ion and ion style semantics. Unlimited numbers.
aceb0c5
@nrnhines
Merge branch 'master' into hines/ions
74d6029
@azure-pipelines Azure Pipelines
Copy link

✔️ aceb0c5 -> Azure artifacts URL

@nrnhines nrnhines mentioned this pull request Sep 30, 2024
Merged
@azure-pipelines Azure Pipelines
Copy link

✔️ 7223c0c -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
Base automatically changed from hines/ions-unlimited to master October 1, 2024 14:37
@azure-pipelines Azure Pipelines
Copy link

✔️ 3e3358a -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ bc44c53 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@nrnhines nrnhines requested review from pramodk and 1uc October 24, 2024 00:03
@1uc
Copy link
Collaborator

1uc commented Oct 24, 2024

The CI failure isn't obviously benign, i.e. a timeout or similar; but it's also hard to imagine that it's related.

>           raise Exception("max diff {} > {}".format(max_diff, tolerance))
E           Exception: max diff 5.088799056284889e-08 > 5e-08

1uc
1uc approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

src/nrnoc/init.cpp Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@azure-pipelines Azure Pipelines
Copy link

✔️ b6f9307 -> Azure artifacts URL

@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.18%. Comparing base (13e183b) to head (b6f9307).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3097   +/-   ##
=======================================
  Coverage   67.18%   67.18%           
=======================================
  Files         572      573    +1     
  Lines      111399   111408    +9     
=======================================
+ Hits        74846    74854    +8     
- Misses      36553    36554    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #236583 (:white_check_mark:) have been uploaded here!

Status and direct links:

@nrnhines nrnhines merged commit cd7ac7d into master Oct 25, 2024
37 checks passed
@nrnhines nrnhines deleted the hines/ions-unlimited-semantics branch October 25, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1uc 1uc 1uc approved these changes

@pramodk pramodk Awaiting requested review from pramodk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrnhines @bbpbuildbot @1uc @wthun