Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handling null response from navigator.credentials.create #1191

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

hcho112
Copy link
Contributor

@hcho112 hcho112 commented Oct 12, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This PR contains small change on biometric-ed25519 package where upon creating passkey from the browser, sometimes it is possible that navigator.credentials.create({ publicKey }) code can return null and it breaks the flow without being handled.

There was an issue reported and discussed that reflect the outcome of this PR.

Test Plan

(I have locally imported this change and run account creation flow on fast-auth-signer repo and it shows alert as expected)

Related issues/PRs

issue

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: b3617f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@near-js/biometric-ed25519 Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/biometric-ed25519/src/index.ts Outdated Show resolved Hide resolved
packages/biometric-ed25519/src/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andy-haynes I have just noticed this PR. It looks good to me. Should we merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants