-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handling null response from navigator.credentials.create #1191
Conversation
🦋 Changeset detectedLatest commit: b3617f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andy-haynes I have just noticed this PR. It looks good to me. Should we merge it?
Pre-flight checklist
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
This PR contains small change on
biometric-ed25519
package where upon creating passkey from the browser, sometimes it is possible thatnavigator.credentials.create({ publicKey })
code can return null and it breaks the flow without being handled.There was an issue reported and discussed that reflect the outcome of this PR.
Test Plan
(I have locally imported this change and run account creation flow on
fast-auth-signer
repo and it showsalert
as expected)Related issues/PRs
issue