Merge pull request #1191 from near/biometric-handling-null

feat: handling null response from navigator.credentials.create
near · Oct 31, 2023 · b5dcd8a · b5dcd8a
2 parents 695220e + b3617f9
commit b5dcd8a
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/.changeset/nice-worms-arrive.md b/.changeset/nice-worms-arrive.md
@@ -0,0 +1,5 @@
+---
+"@near-js/biometric-ed25519": minor
+---
+
+Handing null response on create key flow
diff --git a/packages/biometric-ed25519/package.json b/packages/biometric-ed25519/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@near-js/biometric-ed25519",
   "description": "JavaScript library to handle webauthn and biometric keys",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "scripts": {

diff --git a/packages/biometric-ed25519/src/index.ts b/packages/biometric-ed25519/src/index.ts
@@ -34,6 +34,13 @@ function setBufferIfUndefined() {
     }
 }
 
+export class PasskeyProcessCanceled extends Error {
+    constructor(message) {
+        super(message);
+        this.name = 'PasskeyProcessCanceled';
+    }
+}
+
 export const createKey = async (username: string): Promise<KeyPair> => {
     const cleanUserName = validateUsername(username);
     if (!f2l.f2l) {
@@ -51,6 +58,10 @@ export const createKey = async (username: string): Promise<KeyPair> => {
     setBufferIfUndefined();
     return navigator.credentials.create({ publicKey })
         .then(async (res) => {
+            if (!res) {
+                throw new PasskeyProcessCanceled('Failed to retrieve response from navigator.credentials.create');
+            }
+
             const result = await f2l.attestation({
                 clientAttestationResponse: res,
                 origin,