-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
79 add nbmake or equivalent pytest extension for notebook e2e tests #87
79 add nbmake or equivalent pytest extension for notebook e2e tests #87
Conversation
13e1045
to
911ab5d
Compare
@John-Sharples and @tennlee, here is the notebook stage, note I needed to amend the |
b6418bb
to
1b6a782
Compare
this comment is no longer relevant. I found that the issue was with the extra quotations needed because of the spaces in the notebook name. I've fixed it by renaming the notebooks to use capitalised snake_case and this works well. I suggest all files should be named without spaces to ensure compatibility with linux tools. This is ready to review with this mornings conflict resolved. |
27997e1
to
a6d79f8
Compare
a6d79f8
to
7325bdb
Compare
@tennlee, Ready for review, turned out the coverage through a non editable install fails to return any coverage as the code it runs off is in a different location that the repository in the runner. Adding EDIT: I just pushed a419bd0 which remove stages on push, which duplicates the stages when also running on a pull request. Since all code that goes into |
A new score or metric should be developed on a separate feature branch, rebased against the main branch. Each merge request should include:
All merge requests should comply with the coding standards outlined in this document. Merge requests will undergo both a code review and a science review. The code review will focus on coding style, performance and test coverage. The science review will focus on the mathematical correctness of the implementation and the suitability of the method for inclusion within 'scores'.
A github ticket should be created explaining the metric which is being implemented and why it is useful.