Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nbmake or equivalent pytest extension for notebook e2e tests #79

Closed
aidanjgriffiths opened this issue Oct 19, 2023 · 3 comments · Fixed by #87
Closed

Add nbmake or equivalent pytest extension for notebook e2e tests #79

aidanjgriffiths opened this issue Oct 19, 2023 · 3 comments · Fixed by #87
Assignees
Milestone

Comments

@aidanjgriffiths
Copy link
Collaborator

Add nbmake stage for notebook e2e tests to ensure notebooks don’t break during PRs.

https://github.com/treebeardtech/nbmake

@aidanjgriffiths aidanjgriffiths self-assigned this Oct 19, 2023
@aidanjgriffiths aidanjgriffiths added this to the Wishlist milestone Nov 1, 2023
@aidanjgriffiths
Copy link
Collaborator Author

aidanjgriffiths commented Nov 1, 2023

Lol, ran pytest --nbmake tutorials/ and only 3 notebooks passed without failure😄 .
image

@tennlee
Copy link
Collaborator

tennlee commented Nov 1, 2023

Thanks for looking into this. For anyone else who might be reading along, I have been manually testing the notebooks carefully during the process of creating a release, so released versions should be stable and reliable. Having an effective CI/CD step would be really helpful, thank you.

@aidanjgriffiths
Copy link
Collaborator Author

aidanjgriffiths commented Nov 1, 2023

No worries, its something I had to do about 3 years ago without a nice pytest extension so I'm partially interested on how well this works. I think most of the notebooks are failing due to not having the obs anf fcsts netcdfs cached locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants