Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERNAL: Upgrade ZK Client dependency version from 3.4.14 to 3.5.9 #664

Merged
merged 1 commit into from
Sep 5, 2023
Merged

INTERNAL: Upgrade ZK Client dependency version from 3.4.14 to 3.5.9 #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
<dependency>
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
<version>3.4.14</version>
<version>3.5.9</version>
<exclusions>
<exclusion>
<groupId>log4j</groupId>
Expand Down Expand Up @@ -135,6 +135,7 @@
<arg>-Xlint:all</arg>
<arg>-Xlint:-options</arg> <!-- For warning about old java version 6. -->
<arg>-Xlint:-processing</arg> <!-- For meaningless warning about annotations -->
<arg>-Xlint:-classfile</arg> <!-- For provided spotbugs in ZK Client -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

질문입니다

  • classfile 관련 워닝이 빌생되지 않도록 하는 것인기요?
  • provided scope의 의존성을 가지면 classfile 관련 어떤 워닝이 발생하나요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아래의 워닝이 발생하며, 해당 워닝이 발생하지 않도록 하는 컴파일 옵션입니다.

[WARNING] Cannot find annotation method 'value()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressFBWarnings not found
[WARNING] Cannot find annotation method 'justification()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings'
[WARNING] Cannot find annotation method 'value()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings'
[WARNING] Cannot find annotation method 'justification()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings'
[WARNING] Cannot find annotation method 'value()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings'
[WARNING] Cannot find annotation method 'justification()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings'

<arg>-Werror</arg>
</compilerArgs>
</configuration>
Expand Down
Loading