INTERNAL: Upgrade ZK Client dependency version from 3.4.14 to 3.5.9 #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brido4125
approved these changes
Sep 5, 2023
jhpark816
reviewed
Sep 5, 2023
| @@ -135,6 +135,7 @@ | |||
| <arg>-Xlint:all</arg> | |||
| <arg>-Xlint:-options</arg> <!-- For warning about old java version 6. --> | |||
| <arg>-Xlint:-processing</arg> <!-- For meaningless warning about annotations --> | |||
| <arg>-Xlint:-classfile</arg> <!-- For provided spotbugs in ZK Client --> | |||
There was a problem hiding this comment.
질문입니다
- classfile 관련 워닝이 빌생되지 않도록 하는 것인기요?
- provided scope의 의존성을 가지면 classfile 관련 어떤 워닝이 발생하나요?
There was a problem hiding this comment.
아래의 워닝이 발생하며, 해당 워닝이 발생하지 않도록 하는 컴파일 옵션입니다.
[WARNING] Cannot find annotation method 'value()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressFBWarnings not found
[WARNING] Cannot find annotation method 'justification()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings'
[WARNING] Cannot find annotation method 'value()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings'
[WARNING] Cannot find annotation method 'justification()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings'
[WARNING] Cannot find annotation method 'value()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings'
[WARNING] Cannot find annotation method 'justification()' in type 'edu.umd.cs.findbugs.annotations.SuppressFBWarnings'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK 17 이슈 대응을 위한 ZK Client 의존성 버전 업데이트입니다.
추가 변경 사항
ZK Client 3.5.9에 포함된 의존성 중 하나가 scope provided로 포함되어 있습니다.
arcus-java-client 컴파일 옵션에
-Xlint:-classfile을 추가하는 이유는 위 의존성의 scope가 provided이기 때문입니다.provided
provided는 컴파일 하는 시점에 참조되지만, 컴파일 결과물에는 포함되지 않습니다.
ZK Client 3.5.9에서 이 의존성을 사용하면서도 scope를 provided로 명시했기 때문에 ZK Client 빌드 결과물에 포함되지 않습니다.
따라서 arcus-java-client를 컴파일 하려고 하면 어노테이션을 찾을 수 없다고 컴파일 워닝이 찍힙니다.
SupressFBWarnings 어노테이션의 Retention이 Runtime에 참조할 수 없는 어노테이션이기 때문에 컴파일 워닝을 무시해도 정상적으로 동작합니다.