Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing wrong encodeURI for thumbnail URLs in the admin interface #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removing wrong encodeURI for thumbnail URLs in the admin interface #161

wants to merge 1 commit into from

Commits on Aug 29, 2019

  1. Removing wrong encodeURI for thumbnail URLs in the admin interface 

    The encodeURI is only working by accident. The image URLs in ezp do not contain any characters that need encoding. So the output with or without encodeURI is always the same. It's causing an issue with the image server, because we allow other characters like Umlaute etc. The extra encodeURI is breaking the URL to the image.
eZ is using `eZURI::transformURI( $thumbUrl, true, null, false );` to build the thumbnail URL. I don't see why we'd need encodeURI before we set an image src tag.
    @pkamps
    pkamps authored Aug 29, 2019
    Configuration menu
    Copy the full SHA
    822c599 View commit details
    Browse the repository at this point in the history