Removing wrong encodeURI for thumbnail URLs in the admin interface #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The encodeURI is only working by accident. The image URLs in ezp do not contain any characters that need encoding. So the output with or without encodeURI is always the same. It's causing an issue with the image server, because we allow other characters like Umlaute etc. The extra encodeURI is breaking the URL to the image. eZ is using `eZURI::transformURI( $thumbUrl, true, null, false );` to build the thumbnail URL. I don't see why we'd need encodeURI before we set an image src tag.
|
What about spaces? I saw some discussion about the new stack having issues with spaces in file names. Also, why does the image server need to support more characters than eZ does? |
|
The URLs are coming from an ezjscore ajax service. I don't see how the service would return a list of URLs that are not valid and that need a javascript encodeURI. It's not like we'd add a query parameter and need to escape/encode the URL. The javascript is setting the 'src' tag value. It's less work to support all chars you can use in file names on a file system. I don't need to write extra code to filter out specific chars. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The encodeURI is only working by accident. The image URLs in ezp do not contain any characters that need encoding. So the output with or without encodeURI is always the same. It's causing an issue with the image server, because we allow other characters like Umlaute etc. The extra encodeURI is breaking the URL to the image.
eZ is using
eZURI::transformURI( $thumbUrl, true, null, false );to build the thumbnail URL. I don't see why we'd need encodeURI before we set an image src tag.