Refactor FXIOS-9968 Studies opt out on Firefox iOS when telemetry usage is unchecked (backport #21917) #22009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…ge is unchecked (#21917) Refactor FXIOS-9968 Studies opt out on Firefox iOS when telemetry usage is unchecked (cherry picked from commit 4a11949)
mergify
bot
requested review from
mattreaganmozilla
and removed request for
a team
6 tasks
nbhasin2
requested review from
nbhasin2
and removed request for
mattreaganmozilla
|
FYI: This is for v131 weekly release |
Client.app: Coverage: 30.87
Generated by 🚫 Danger Swift against 032edcb |
|
@mergify update |
✅ Branch has been successfully updated |
dsmithpadilla
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket - FXIOS-9968
Github issue
💡 Description
These should mostly be visual changes but I did add additional check to ensure we also disable the toggle and save it in prefs.
Although experiments are by default disabled if you are not reporting telemetry > LINK
Below are some cases I added in the video.
A) Initially both are enabled
B) Turning telemetry Off should also turn Off studies
C) Turning telemetry On doesn't automatically turn on studies
FYI Studies are another name for experiments.
Screen.Recording.2024-09-12.at.12.39.30.AM.mov
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)This is an automatic backport of pull request #21917 done by [Mergify](https://mergify.com).