Refactor FXIOS-9968 Studies opt out on Firefox iOS when telemetry usage is unchecked

[nbhasin2]

📜 Tickets

Jira ticket - FXIOS-9968
Github issue

💡 Description

These should mostly be visual changes but I did add additional check to ensure we also disable the toggle and save it in prefs.

Although experiments are by default disabled if you are not reporting telemetry > LINK

Below are some cases I added in the video.

A) Initially both are enabled
B) Turning telemetry Off should also turn Off studies
C) Turning telemetry On doesn't automatically turn on studies

FYI Studies are another name for experiments.

Screen.Recording.2024-09-12.at.12.39.30.AM.mov

📝 Checklist

You have to check all boxes before merging

• Filled in the above information (tickets numbers and description of your work)
• Updated the PR name to follow our PR naming guidelines
• Wrote unit tests and/or ensured the tests suite is passing
• When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
• If needed, I updated documentation / comments for complex code and public methods
• If needed, added a backport comment (example @Mergifyio backport release/v120)

[nbhasin2]

cc @jeffreygee Tagging you here since you are working on Settings IA and this is unique case which would be best solved if these are somehow combined together or embedded in another view. Having it on top of settings seems odd and doesn't give user enough knowledge about turning of ONE would also turn OFF other.

See above video for your reference

[mobiletest-ci-bot]

	Messages
📖	Project coverage: 31.65%
📖	Edited 4 files
📖	Created 0 files

Client.app: Coverage: 30.41

File	Coverage
SettingsTableViewController.swift	14.45%	⚠️
AppSettingsTableViewController.swift	27.59%	⚠️
StudiesToggleSetting.swift	70.27%	✅
SendAnonymousUsageDataSetting.swift	74.58%	✅

Generated by 🚫 Danger Swift against b887870

[ih-codes]

Seems to work well when I tested. 👍

I did see the toggle freeze up once like you described in Coffee Chat yesterday, but I couldn't reproduce it. Might be because I stopped at a breakpoint during initialization. Anyway, seems very edge case.

I left a few comments. You can see if any of them are something to worry about.

[nbhasin2]

@mergify backport release/v131

[mergify]

backport release/v131

✅ Backports have been created

• #22009 Refactor FXIOS-9968 Studies opt out on Firefox iOS when telemetry usage is unchecked (backport #21917) has been created for branch release/v131