-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update acceleration limits for robot configs #195
Conversation
Signed-off-by: Paul Gesel <[email protected]>
Signed-off-by: Paul Gesel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding a comment why has_jerk_limits: false
for all joints in a file called joint_limits_jerk_limited
? I think that might be confusing otherwise
@sjahr That is a good point. The problem is that |
👍 Yes, I like that. Let's do it |
Signed-off-by: Paul Gesel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
So the plan is to use this new file for our servo examples going forward, then?
Yes, we can use these limits in servo for better control. |
See #194 for more detail. I think some discussion on how to manage different sets of
joint_limits.yaml
could be beneficial.