-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #826
Fix CI #826
Conversation
Next segfault to fix. Seems to come from the
|
@Abishalini I ran into this locally and reported here: ros2/rcl#1118 I got a suggestion to try out but hadn't got to that. Apparently we may be publishing 2 separate message types to a specific topic and that causes the segfault? But also, switching to Cyclone DDS gets around this issue. |
@sea-bass Thanks for the pointer! I will dig a little deeper into this now Potential solution for the segfault - moveit/moveit2#2561 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The htmlproofer failure is because of the Python bindings. I will look into this in a separate PR to moveit2, so this LGTM.
EDIT: My fix to this is in moveit/moveit2#2563, plus another lingering dead link I mentioned in #820 (comment)
* Add ros2 kortex to upstream repos * Update to commit with planning pipeline refactor change * Add ros2_robotiq_gripper repo for source build * Add serial to .repos file * Add ros2_robotiq_gripper to moveit2_tutorials.repo * Remove dead link (cherry picked from commit b2cd6c0) # Conflicts: # .github/upstream.repos # moveit2_tutorials.repos
ros2_kortex
as a source build since CI is failing as it does not have the latest changes inros2_kortex
repo regarding the planning pipeline refactor.Fixing the ros2_kortex repo to
Also, added
ros2_robotiq_gripper
repo as a source build to fix the invalid parameter error - moveit2_tutorials demo.launch.py not working #821This PR also brings in fake_components -> mock_components Kinovarobotics/ros2_kortex#197 to fix the
fake_components
deprecation.