Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpcs phpdoc fixes #15

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Phpcs phpdoc fixes #15

merged 6 commits into from
Apr 25, 2024

Commits on Apr 18, 2024

  1. Let's make CI stricter (phpcs and phpdoc)

    This makes phpcs stricter (not warnings allowed) and, also,
    enabled phpdoc tests.
    
    That way we have all the moodle-plugin-ci tests passing for
    the repository and ready to check any future improvement to it.
    
    Fixes moodlehq#13
    
    Also, renew the php/branches combinations and remove some
    deprecated stuff.
    stronk7 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1d6067e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    555a7fb View commit details
    Browse the repository at this point in the history
  3. Change all http:// links to https://

    Just a bulk change, so we have all them moved.
    stronk7 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    fec98c1 View commit details
    Browse the repository at this point in the history
  4. Fix all the phpcs detected errors and warnings

    Have kept the UselessOverridingMethod ignored, because
    I only wanted to introduce here the minimum changes needed.
    Basically:
     - superfluous MOODLE_INTERNAL checks.
     - deprecated print_error() uses.
     - Logical operators (or => ||).
     - small namespace issues in tests.
    stronk7 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b34d9fd View commit details
    Browse the repository at this point in the history
  5. Fix the info page by moving to lang string

    Also, updated to show the link to the matrix chat room
    stronk7 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a11194d View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. More coding-style cleanup

    arrays syntax, test requirements, lang string ordering... nothing
    critical, so far.
    
    Also, add 404-STABLE to tests, part of MDLSITE-7646
    stronk7 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f10ecaf View commit details
    Browse the repository at this point in the history