Phpcs phpdoc fixes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stronk7
force-pushed
the
phpcs_phpdoc_fixes
branch
from
5fe47af
to
8f84615
Compare
|
This job (in my fork, where GHA is already enabled) shows how, with the changes in this PR, both phpdoc and phpcs are now happy, 100% free from any warning / error. https://github.com/stronk7/moodle-local_chatlogs/actions/runs/4925151869 Ciao :-) IMPORTANT NOTE: This is built on top of #14 , where GHA support is added, so it must be merged after it. |
stronk7
force-pushed
the
phpcs_phpdoc_fixes
branch
3 times, most recently
from
38621eb
to
f78bbf7
Compare
This makes phpcs stricter (not warnings allowed) and, also, enabled phpdoc tests. That way we have all the moodle-plugin-ci tests passing for the repository and ready to check any future improvement to it. Fixes moodlehq#13 Also, renew the php/branches combinations and remove some deprecated stuff.
Just a bulk change, so we have all them moved.
Have kept the UselessOverridingMethod ignored, because I only wanted to introduce here the minimum changes needed. Basically: - superfluous MOODLE_INTERNAL checks. - deprecated print_error() uses. - Logical operators (or => ||). - small namespace issues in tests.
Also, updated to show the link to the matrix chat room
stronk7
force-pushed
the
phpcs_phpdoc_fixes
branch
from
f78bbf7
to
865947e
Compare
arrays syntax, test requirements, lang string ordering... nothing critical, so far. Also, add 404-STABLE to tests, part of MDLSITE-7646
stronk7
force-pushed
the
phpcs_phpdoc_fixes
branch
from
865947e
to
f10ecaf
Compare
|
Friendly pong! |
mudrd8mz
reviewed
Apr 25, 2024
mudrd8mz
approved these changes
Apr 25, 2024
Thanks a lot! |
|
tata! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes 6 commits (see them for details):
Should fix #13
Ciao :-)
IMPORTANT NOTE: This is built on top of #14 , where GHA support is added, so it must be merged after it.