Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More PR template updates #452

Merged
merged 1 commit into from
Feb 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 27 additions & 31 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,47 +1,43 @@
Resolves #ISSUE(s).
<!--- "Resolves #ISSUE" will automatically close #ISSUE when the PR is merged. However, if this PR won't 100% address the issue, you can use one of these patterns instead to simply link to the issue and not auto-close it:

Partially addresses:
- ISSUE(s)

Addresses sub-task (n) in:
- ISSUE(s)
<!--- "Resolves #ISSUE" will automatically close #ISSUE when the PR is merged. However, if this PR won't 100% address
twhetzel marked this conversation as resolved.
Show resolved Hide resolved
the issue and you don't want it to auto-close, you can write one of the following instead of "Resolves"
- Partially addresses
- Addresses sub-task (n) in
-->


## Pre-merge checklist

<!--- Docs: A common case for documentation is the addition of new `make` goals. Descriptions should be documented for new goals both in the (i) `help` command at the bottom of the `mondo-ingest.Makefile` and (ii) `docs/developer/workflows.md`. -->

### PR Overview
<!--- Short paragraph or short bulleted list describing changes in this PR -->

## Overview
<!--- A few sentences describing changes / what problem is solved. Should describe the expected result of the changes.
twhetzel marked this conversation as resolved.
Show resolved Hide resolved
twhetzel marked this conversation as resolved.
Show resolved Hide resolved
If applicable, point out the main change that solved the problem, e.g. fixed bug in method xyz. -->
This PR:
- One
- Two
- Three

=====================
twhetzel marked this conversation as resolved.
Show resolved Hide resolved
## Pre-merge checklist
<!--- Docs: A common case for documentation is the addition of new `make` goals. Descriptions should be documented for
new goals both in the (i) `help` command at the bottom of the `mondo-ingest.Makefile` and (ii)
`docs/developer/workflows.md`. -->

### Documentation
- Was the documentation added/updated under `docs/`?
twhetzel marked this conversation as resolved.
Show resolved Hide resolved
- [ ] Yes
- [ ] No, updates to the docs were not necessary after careful consideration
Was the documentation added/updated under `docs/`?
- [ ] Yes
- [ ] No, updates to the docs were not necessary after careful consideration

### QC
- Was the full pipeline run before submitting this PR using `sh run.sh make build-mondo-ingest` on this branch (after `docker pull obolibrary/odkfull:dev`), and no errors occurred?
- [ ] Yes
- [ ] No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary
Was the full pipeline run before submitting this PR using `sh run.sh make build-mondo-ingest` on this branch (after
`docker pull obolibrary/odkfull:dev`), and no errors occurred?
- [ ] Yes
- [ ] No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

### New Packages
- Were any new *Python packages* added?
- [ ] Yes, [requirements.txt.full](https://github.com/INCATools/ontology-development-kit/blob/master/requirements.txt.full) was updated and an [ODK issue](https://github.com/INCATools/ontology-development-kit/issues/new) submitted
- [ ] No
</br>
Were any new *Python packages* added?
- [ ] Yes, [requirements.txt.full](https://github.com/INCATools/ontology-development-kit/blob/master/requirements.txt.full) was updated and an [ODK issue](https://github.com/INCATools/ontology-development-kit/issues/new) submitted
- [ ] No

- Were any other *non-Python packages* added?
- [ ] Yes, [Dockerfile](https://github.com/INCATools/ontology-development-kit/blob/master/Dockerfile) updated and an [ODK issue](https://github.com/INCATools/ontology-development-kit/issues/new) submitted
- [ ] No
Were any other *non-Python packages* added?
- [ ] Yes, [Dockerfile](https://github.com/INCATools/ontology-development-kit/blob/master/Dockerfile) updated and an [ODK issue](https://github.com/INCATools/ontology-development-kit/issues/new) submitted
- [ ] No

### PR Review and Conversations Resolved
- Has the PR been sufficiently reviewed by at least one team member of the Mondo Technical team and all threads resolved?
- [ ] Yes
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?
- [ ] Yes