Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More PR template updates #452

Merged
merged 1 commit into from
Feb 23, 2024
Merged

More PR template updates #452

merged 1 commit into from
Feb 23, 2024

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Feb 22, 2024

Overview

Did some further updates following #430.

Pre-merge checklist

=====================

Documentation

  • Was the documentation added/updated under docs/?
    • Yes
    • No, updates to the docs were not necessary after careful consideration

QC

  • Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after docker pull obolibrary/odkfull:dev), and no errors occurred?
    • Yes
    • No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages


  • Were any other non-Python packages added?

PR Review and Conversations Resolved

  • Has the PR been sufficiently reviewed by at least one team member of the Mondo Technical team and all threads resolved?
    • Yes

Change details

PR template update

  • Updated comment regarding 'resolves ISSUE' to be more concise and readable.
  • Rename section: PR Overview -> Overview
  • Moved Overview out of and above the Pre-merge checklist section
  • Updated comment for Overview section
  • Codestyle: (i) Added line breaks to adhere to a 100 character line limit, (ii) Removed some visually redundant bullet indentation.

- Updated comment regarding 'resolves ISSUE' to be more concise and readable.
- Rename section: PR Overview -> Overview
- Moved Overview out of and above the Pre-merge checklist section
- Updated comment for Overview section
- Codestyle: (i) Added line breaks to adhere to a 100 character line limit, (ii) Removed some visually redundant bullet indentation.
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
@joeflack4 joeflack4 added the documentation Improvements or additions to documentation label Feb 22, 2024
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
@joeflack4
Copy link
Contributor Author

Double-approved! So merging.

@joeflack4 joeflack4 merged commit 953f0da into main Feb 23, 2024
@joeflack4 joeflack4 deleted the pr-template-update branch February 23, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants