Merge pull request #240 from mlibrary/LIBSEARCH-814-account-remove-fa…

…vorites-from-account-navigation

[LIBSEARCH-814] ACCOUNT: Remove "Favorites" from Account navigation

config/navigation.json

@@ -113,16 +113,6 @@
       "message": "Fines are charged for <a href=\"https://lib.umich.edu/find-borrow-request/borrow-and-return/reminders-and-overdue-items/lost-items\">lost items</a>."
     }
   },
-  {
-    "title": "Favorites",
-    "description": "View items you've added to your favorites.",
-    "icon_name": "star",
-    "color": "maize",
-    "empty_state": {
-      "heading": "You haven't added any favorites.",
-      "message": "You can save items to appear here by selecting “Save to Favorites” when viewing an item record in <a href=\"https://search.lib.umich.edu/everything?query=&utm_source=lib-home\">Library Search</a>."
-    }
-  },
   {
     "title": "Settings",
     "description": "Review your contact information and update your account preferences.",

lib/navigation/navigation.rb

@@ -1,6 +1,6 @@
 class Navigation
   def self.cards
-    Entities::Pages.all[1, 6]
+    Entities::Pages.all[1, 5]
   end
 
   def self.home

spec/lib/navigation/navigation_spec.rb

@@ -7,7 +7,7 @@
       expect(subject.find { |x| x.title == "Account Overview" }).to be_nil
     end
     it "should have 6 elements" do
-      expect(subject.count).to eq(6)
+      expect(subject.count).to eq(5)
     end
   end
   context ".home" do

spec/lib/navigation/sidebar_spec.rb

@@ -4,7 +4,7 @@
       described_class.for("/")
     end
     it "has pages all top-level pages that are not hidden from the sidebar" do
-      expect(subject.pages.count).to eq(7)
+      expect(subject.pages.count).to eq(6)
     end
     it "has correct active page" do
       expect(subject.pages.first.active?).to eq(true)