Skip to content

Commit

Permalink
Removing My Favorites from navigation
Browse files Browse the repository at this point in the history
  • Loading branch information
erinesullivan committed Nov 14, 2022
1 parent a9ee99e commit d0e628a
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 13 deletions.
10 changes: 0 additions & 10 deletions config/navigation.json
Original file line number Diff line number Diff line change
Expand Up @@ -113,16 +113,6 @@
"message": "Fines are charged for <a href=\"https://lib.umich.edu/find-borrow-request/borrow-and-return/reminders-and-overdue-items/lost-items\">lost items</a>."
}
},
{
"title": "Favorites",
"description": "View items you've added to your favorites.",
"icon_name": "star",
"color": "maize",
"empty_state": {
"heading": "You haven't added any favorites.",
"message": "You can save items to appear here by selecting “Save to Favorites” when viewing an item record in <a href=\"https://search.lib.umich.edu/everything?query=&utm_source=lib-home\">Library Search</a>."
}
},
{
"title": "Settings",
"description": "Review your contact information and update your account preferences.",
Expand Down
2 changes: 1 addition & 1 deletion lib/navigation/navigation.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
class Navigation
def self.cards
Entities::Pages.all[1, 6]
Entities::Pages.all[1, 5]
end

def self.home
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/navigation/navigation_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
expect(subject.find { |x| x.title == "Account Overview" }).to be_nil
end
it "should have 6 elements" do
expect(subject.count).to eq(6)
expect(subject.count).to eq(5)
end
end
context ".home" do
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/navigation/sidebar_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
described_class.for("/")
end
it "has pages all top-level pages that are not hidden from the sidebar" do
expect(subject.pages.count).to eq(7)
expect(subject.pages.count).to eq(6)
end
it "has correct active page" do
expect(subject.pages.first.active?).to eq(true)
Expand Down

0 comments on commit d0e628a

Please sign in to comment.