Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Improve macOS fallback to use less external commands #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions homedir.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,20 @@ func dirUnix() (string, error) {

// If that fails, try OS specific commands
if runtime.GOOS == "darwin" {
cmd := exec.Command("sh", "-c", `dscl -q . -read /Users/"$(whoami)" NFSHomeDirectory | sed 's/^[^ ]*: //'`)
cmd := exec.Command("id", "-un")
cmd.Stdout = &stdout
if err := cmd.Run(); err == nil {
result := strings.TrimSpace(stdout.String())
if result != "" {
return result, nil
username := string(bytes.TrimSpace(stdout.Bytes()))
stdout.Reset()
if username != "" {
cmd = exec.Command("dscl", "-q", ".", "-read", "/Users/"+username, "NFSHomeDirectory")
cmd.Stdout = &stdout
if err := cmd.Run(); err == nil {
result := strings.TrimSpace(strings.TrimPrefix(stdout.String(), "NFSHomeDirectory: "))
if result != "" {
return result, nil
}
}
}
}
} else {
Expand Down