Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move backwards compatibility code #133

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Move backwards compatibility code #133

merged 3 commits into from
Sep 7, 2023

Conversation

reynir
Copy link
Member

@reynir reynir commented Sep 6, 2023

We need to apply the "fix" when GNU LongLink/LongName is used, too.

Reported and fixed by @gravicappa in #129

We need to apply the "fix" when GNU LongLink/LongName is used, too.

Reported and fixed by @gravicappa
@reynir reynir mentioned this pull request Sep 6, 2023
In order to fix CI
@reynir
Copy link
Member Author

reynir commented Sep 7, 2023

Added an upper constraint on eio.

@reynir reynir merged commit a1cbf1e into main Sep 7, 2023
1 of 3 checks passed
@reynir reynir deleted the fix-129 branch September 7, 2023 09:47
reynir added a commit to reynir/opam-repository that referenced this pull request Sep 7, 2023
CHANGES:

- Add eio backend for tar in `tar-eio` (@patricoferris, review by @talex5, @reynir, mirage/ocaml-tar#132)
- Also apply backwards compatibility fix when GNU LongName is used.
  The compatibility fix is unfortunately also applied for unknown-to-ocaml-tar link indicators (reported by @gravicappa in mirage/ocaml-tar#129, @reynir, mirage/ocaml-tar#133)
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
CHANGES:

- Add eio backend for tar in `tar-eio` (@patricoferris, review by @talex5, @reynir, mirage/ocaml-tar#132)
- Also apply backwards compatibility fix when GNU LongName is used.
  The compatibility fix is unfortunately also applied for unknown-to-ocaml-tar link indicators (reported by @gravicappa in mirage/ocaml-tar#129, @reynir, mirage/ocaml-tar#133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant