[new release] tar (4 packages) (2.6.0) #24371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: - Add eio backend for tar in `tar-eio` (@patricoferris, review by @talex5, @reynir, mirage/ocaml-tar#132) - Also apply backwards compatibility fix when GNU LongName is used. The compatibility fix is unfortunately also applied for unknown-to-ocaml-tar link indicators (reported by @gravicappa in mirage/ocaml-tar#129, @reynir, mirage/ocaml-tar#133)
mseri
reviewed
Sep 7, 2023
| depends: [ | ||
| "dune" {>= "2.9"} | ||
| "ocaml" {>= "4.08.0"} | ||
| "eio" {>= "0.10.0" & < "0.12"} |
There was a problem hiding this comment.
Is it already known to break for eio 0.12 or newer?
There was a problem hiding this comment.
seems like it:
> File "eio/tar_eio.mli", line 23, characters 57-72:
> 23 | val get_next_header : ?level:Tar.Header.compatibility -> Eio.Flow.source ->
> ^^^^^^^^^^^^^^^
> Error: The type constructor Eio.Flow.source expects 1 argument(s),
> but is here applied to 0 argument(s)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decode and encode tar format files in pure OCaml
CHANGES:
tar-eio(@patricoferris, review by @talex5, @reynir, Add eio backend for tar mirage/ocaml-tar#132)The compatibility fix is unfortunately also applied for unknown-to-ocaml-tar link indicators (reported by @gravicappa in Tar.Header.Header.unmarshal should treat
Normalentries with trailing slash name asDirectory. mirage/ocaml-tar#129, @reynir, Move backwards compatibility code mirage/ocaml-tar#133)