-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Multi Report to comply to the new report flow #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Rieven
changed the title
Fix/multi report
Refactor Multi Report to comply to the new report flow
Oct 22, 2024
You can see the translation also in your screenshot. Dont know why you'd translate there :) |
Aha, you didnt change that in this PR. Im sorry. |
Feedback seems to have been implemented correctly. Nice work @Rieven |
Quality Gate passedIssues Measures |
underdarknl
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issue link
#3623
Closes #3623
Demo
Screen.Recording.2024-10-21.at.14.05.16.mov
QA notes
Upload these 2 report datas from upload raw OOI data:
use
openkat/report-data
as mimetypechoose any random ooi from the dropdown list.
do it for these 2 report data
aggregate_report_mispo.es.json
aggregate_report_minvws.json
Then...
Create a multi report and choose these 2 oois.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.