Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Multi Report to comply to the new report flow #3705

Merged
merged 22 commits into from
Oct 30, 2024

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Oct 21, 2024

Changes

  • Fix the report flow from beginning to end
  • Created 2 aggregate reports from 2 organisations.
  • Downloaded the aggregate data for both organisations
  • Inserted these 2 aggregate data as Report Data in one of the organisations
  • Created a Multi report from these 2 aggregate reportData oois.
  • removed get requests
  • Fix ooi type when no OOI type is filtered.
  • Added test for this flow

Issue link

#3623

Closes #3623

Demo

Screen.Recording.2024-10-21.at.14.05.16.mov

QA notes

Upload these 2 report datas from upload raw OOI data:

image

use openkat/report-data as mimetype
choose any random ooi from the dropdown list.

do it for these 2 report data
aggregate_report_mispo.es.json
aggregate_report_minvws.json

Then...
Create a multi report and choose these 2 oois.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Rieven Rieven requested a review from a team as a code owner October 21, 2024 11:58
@Rieven Rieven mentioned this pull request Oct 22, 2024
9 tasks
@Rieven Rieven changed the title Fix/multi report Refactor Multi Report to comply to the new report flow Oct 22, 2024
@noamblitz
Copy link
Contributor

When generating a multi org report i get this error

image

@Rieven
Copy link
Contributor Author

Rieven commented Oct 22, 2024

When generating a multi org report i get this error

I wonder why you don't have summary in the report data, as for me:
image

Aggregate data appends the summary info:
image

image

@noamblitz
Copy link
Contributor

image Apparently it gets translated????

@noamblitz
Copy link
Contributor

You can see the translation also in your screenshot. Dont know why you'd translate there :)

@noamblitz
Copy link
Contributor

Aha, you didnt change that in this PR. Im sorry.

@Rieven
Copy link
Contributor Author

Rieven commented Oct 22, 2024

image Apparently it gets translated????

fixed in: b2339ae and 15ddbcb

@noamblitz
Copy link
Contributor

noamblitz commented Oct 22, 2024

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.
  • I checked the logs for errors and/or warnings and made issues where necessary

What works:

Seems to work again now! Nice work.

What doesn't work:

Table of contents of appendix is incorrect. Has to be fixed.

image

Needs spaces here

image

Bug or feature?:

Shows only first few of 7?

image

@noamblitz
Copy link
Contributor

Feedback seems to have been implemented correctly. Nice work @Rieven

Copy link

sonarcloud bot commented Oct 30, 2024

@underdarknl underdarknl merged commit 5b33461 into main Oct 30, 2024
27 checks passed
@underdarknl underdarknl deleted the fix/multi-report branch October 30, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

RecursionError at /en/dev/reports/multi-report/select/oois/
3 participants