Fix Multi Report recursion error #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rieven
commented
Oct 22, 2024
| @@ -63,11 +62,6 @@ class OOISelectionMultiReportView(MultiReportStepsMixin, BreadcrumbsMultiReportV | |||
| current_step = 1 | |||
| ooi_types = MultiOrganizationReport.input_ooi_types | |||
|
|
|||
| def get(self, request, *args, **kwargs): | |||
There was a problem hiding this comment.
Removed all get from MultiReport views as we use now post requests.
Rieven
commented
Oct 22, 2024
| messages.error(request, self.NONE_OOI_SELECTION_MESSAGE) | ||
| return redirect(self.get_previous()) | ||
| return self.get(request, *args, **kwargs) | ||
| ooi_types = MultiOrganizationReport.input_ooi_types |
There was a problem hiding this comment.
ooi_types must be present otherwise when selecting all oois it will fetch all ooi types. We want specific ooi types stored in the report types. I have refactor this part in #3705 which is done more efficiently in a get function.
Rieven
commented
Oct 22, 2024
| @@ -314,7 +314,7 @@ def get_context_data(self, **kwargs): | |||
| return context | |||
|
|
|||
|
|
|||
| class ReportTypeSelectionView(BaseReportView, ReportBreadcrumbs, TemplateView): | |||
There was a problem hiding this comment.
TemplateView is removed, it clashes with ListView from the BaseOOILIst. use it in specific views where needed.
Checklist for QA:
What works:No more RecursionError What doesn't work:Cant generate multi-report. Will test other PR now. |
dekkers
approved these changes
Oct 24, 2024
underdarknl
approved these changes
Oct 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issue link
#3623
Closes #3623
Demo
QA notes
The last step will give you a 405 error as this last flow must be refactored see the refactor branch.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.