-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libssh2,libgit2,vcpkg-ci-libgit2] Fix, test, cleanup #32440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
changed the title
[vcpkg-ci-libgit2] Test libgit2[ssh]
[libssh2,libgit2,vcpkg-ci-libgit2] Fix, test, cleanup
Jul 9, 2023
7 tasks
LilyWangLL
added
category:port-bug
The issue is with a library, which is something the port should already support
requires:all-feature-testing
vcpkg install port[all features supported by that port] needs to be demonstrated to function
labels
Jul 10, 2023
LilyWangLL
requested changes
Jul 11, 2023
All features of
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
LilyWangLL
removed
the
requires:all-feature-testing
vcpkg install port[all features supported by that port] needs to be demonstrated to function
label
Jul 11, 2023
LilyWangLL
approved these changes
Jul 11, 2023
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libssh2
Fixes pc file for windows.
Enable building windows without openssl.
libgit2
Generally leverages pkg-config for dependencies:
Fixes #32433 (ssh) by using libssh2 pc files.
Fixes pcre2 debug lib name mismatch.
Rectifies exported unofficial cmake config:
Provide canonical
unofficial-<port>
package/unofficial::<port>::libgit2
target.Drops pointless
find_dependency
.Adds include dir property.
Adds usage hint, for pkg-config and cmake.
Fixes android builds (libgit2/libgit2#6574).
Add
tools
feature.Fix mingw.
Revise copyright notice.
vcpkg-ci-libgit2
New test port, activates ssh and tools features.
./vcpkg x-add-version --all
and committing the result.