Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libssh2,libgit2,vcpkg-ci-libgit2] Fix, test, cleanup #32440

Merged
merged 20 commits into from
Jul 11, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 7, 2023

libssh2

Fixes pc file for windows.
Enable building windows without openssl.

libgit2

Generally leverages pkg-config for dependencies:
Fixes #32433 (ssh) by using libssh2 pc files.
Fixes pcre2 debug lib name mismatch.

Rectifies exported unofficial cmake config:
Provide canonical unofficial-<port> package/unofficial::<port>::libgit2 target.
Drops pointless find_dependency.
Adds include dir property.

Adds usage hint, for pkg-config and cmake.

Fixes android builds (libgit2/libgit2#6574).

Add tools feature.

Fix mingw.

Revise copyright notice.

vcpkg-ci-libgit2

New test port, activates ssh and tools features.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dg0yt dg0yt marked this pull request as draft July 7, 2023 16:57
@dg0yt dg0yt changed the title [vcpkg-ci-libgit2] Test libgit2[ssh] [libssh2,libgit2,vcpkg-ci-libgit2] Fix, test, cleanup Jul 9, 2023
@dg0yt dg0yt marked this pull request as ready for review July 9, 2023 13:23
@dg0yt dg0yt mentioned this pull request Jul 9, 2023
7 tasks
@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Jul 10, 2023
@LilyWangLL
Copy link
Contributor

LilyWangLL commented Jul 11, 2023

All features of libssh2 and feature libgit2[tools] passed on the following triplets:

x86-windows
x64-windows
x64-windows-static

Usage of libssh2 passed on x64-windows.
Usage of libgit2 passed on x64-windows.

@LilyWangLL
Copy link
Contributor

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@LilyWangLL LilyWangLL marked this pull request as draft July 11, 2023 02:56
@LilyWangLL LilyWangLL removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jul 11, 2023
@dg0yt dg0yt marked this pull request as ready for review July 11, 2023 05:31
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jul 11, 2023
@BillyONeal BillyONeal merged commit 505cba2 into microsoft:master Jul 11, 2023
15 checks passed
@BillyONeal
Copy link
Member

Thanks!

@dg0yt dg0yt deleted the libssh2 branch July 11, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libgit2] Build error
3 participants