Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libgit2] Fix feature ssh build error #32435

Closed

Conversation

LilyWangLL
Copy link
Contributor

Fixes #32433, fix feature ssh build error.

--   Found libssh2, version 1.11.0
CMake Error at cmake/FindPkgLibraries.cmake:17 (message):
  could not resolve ssh2
Call Stack (most recent call first):
  cmake/SelectSSH.cmake:3 (find_pkglibraries)
  src/CMakeLists.txt:44 (include)

Usage passed on x64-windows.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 7, 2023
@LilyWangLL LilyWangLL marked this pull request as ready for review July 7, 2023 09:46
@dg0yt
Copy link
Contributor

dg0yt commented Jul 7, 2023

Before this PR:
libssh installs wrong pc files.

With this PR:
libssh and libgit2 install wrong pc files?

@dg0yt
Copy link
Contributor

dg0yt commented Jul 9, 2023

Full story: #32440

@LilyWangLL
Copy link
Contributor Author

Closed as duplicate of #32440.

@LilyWangLL LilyWangLL closed this Jul 11, 2023
@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue32433 branch July 17, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libgit2] Build error
3 participants