Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fluentUI-migration): ActionButton fluentui v8 to v9 migration #7401

Merged
merged 90 commits into from
Sep 19, 2024
Merged

feat(fluentUI-migration): ActionButton fluentui v8 to v9 migration #7401

Show file tree
Hide file tree
Changes from 88 commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
803dadb
action button initial migration
v-rakeshsh Jun 21, 2024
d858b39
Merge branch 'fluent-ui-v8-migration-main' of https://github.com/micr…
v-rakeshsh Jun 24, 2024
a36f0c2
submenu changes
v-rakeshsh Jun 24, 2024
24b7caf
submenu changes
v-rakeshsh Jun 26, 2024
b5af799
submenu changes
v-rakeshsh Jul 1, 2024
f216ea9
test case fix
v-sharmachir Jul 2, 2024
f990b9a
changes in test files
v-sharmachir Jul 3, 2024
0df681f
latest test cases fixes
v-rakeshsh Jul 8, 2024
255638f
latest test cases fixes
v-rakeshsh Jul 10, 2024
46f7535
latest test cases fixes
v-rakeshsh Jul 10, 2024
54266d7
Removed comments from main files, numbers for testing purpose, consol…
v-prachin Jul 12, 2024
4859ff6
chore: Added resolutions in package.json file to resolve CVE-2024-378…
v-rakeshsh Jul 16, 2024
4049316
latest test cases fixes
v-rakeshsh Jul 19, 2024
4e8bd07
latest test cases fixes
v-rakeshsh Jul 23, 2024
6bffc0b
latest test cases fixes
v-rakeshsh Jul 24, 2024
2a1bd21
latest test cases fixes
v-rakeshsh Jul 26, 2024
8c920ad
UI changes fixes
v-rakeshsh Jul 29, 2024
1a00b3c
removed unwanted code
v-rakeshsh Jul 29, 2024
2311cf9
latest test cases fixes
v-rakeshsh Aug 1, 2024
5e06d7f
test cases fixes and code refactor
v-sharmachir Aug 1, 2024
9cfb513
lint issue fix and report e2e fix
v-sharmachir Aug 1, 2024
95d65aa
test cases fixes
v-rakeshsh Aug 1, 2024
bbf8f22
resolve conflicts
v-rakeshsh Aug 1, 2024
7314e05
test cases fix
v-rakeshsh Aug 1, 2024
5814a4e
test cases fix
v-rakeshsh Aug 1, 2024
03ed64d
test cases fix
v-rakeshsh Aug 1, 2024
0feb778
test cases and lint fixes
v-sharmachir Aug 2, 2024
3794ac0
lint issue fix
v-sharmachir Aug 2, 2024
8752586
fixed accessibility issue related to aria-parent-required
v-sharmachir Aug 2, 2024
65c6027
snapshot update
v-sharmachir Aug 2, 2024
f5ac4a1
fixed lint and type issues
v-rakeshsh Aug 5, 2024
62b0ec1
lint and format issue fix
v-sharmachir Aug 5, 2024
447cb39
fix e2e tests
v-rakeshsh Aug 5, 2024
34f33d5
merge latest changes
v-rakeshsh Aug 5, 2024
1c631a3
small change to retrigger build
v-rakeshsh Aug 6, 2024
33ffbb5
lint fix
v-rakeshsh Aug 6, 2024
5120300
fix e2e test case
v-rakeshsh Aug 6, 2024
9924f3a
added condition to normalize dummy tabster
v-sharmachir Aug 6, 2024
45d9bd8
Merge latest
v-sharmachir Aug 6, 2024
2f401cd
fix dropdown menu
v-rakeshsh Aug 6, 2024
a6c1680
latest changes
v-rakeshsh Aug 7, 2024
7e548ce
some styling fixes
v-sharmachir Aug 8, 2024
0fd513e
test case fixes
v-sharmachir Aug 8, 2024
19f55b8
Dialog fix
v-sharmachir Aug 8, 2024
8f43f0c
latest changes
v-sharmachir Aug 8, 2024
a8e75fa
added focus border
v-rakeshsh Aug 8, 2024
7dc56cb
fix focus issues
v-rakeshsh Aug 8, 2024
d38ddbe
initial changes (#7417)
v-rakeshsh Aug 9, 2024
46ac3e3
latest changes
v-sharmachir Aug 9, 2024
e5d198d
latest changes
v-sharmachir Aug 12, 2024
41d4a01
unit test cases fixed
v-sharmachir Aug 13, 2024
5690e31
latest test cases fix for code refactoring
v-rakeshsh Aug 14, 2024
f9e95b5
latest test cases fix for code refactoring
v-rakeshsh Aug 14, 2024
3162910
latest test cases fix for code refactoring
v-rakeshsh Aug 14, 2024
813a0a4
Merge branch 'fluent-ui-v9-migration-main' into v-rakesh/actionbutton…
v-sharmachir Aug 21, 2024
6f49cce
ButtonRefFunction,FocusBorder visible,Moreactions Tooltip,E2E test ca…
JeevaniChinthala Aug 22, 2024
c37d16d
fixiing focus issue
v-rakeshsh Aug 23, 2024
0208c04
fixiing focus issue
v-rakeshsh Aug 23, 2024
f85fc99
Removed unwanted comments, solved deprecated warnings files
v-singhanjal Aug 23, 2024
d8911f3
lint and format fix
v-singhanjal Aug 23, 2024
f8ed166
updated snapshots and test files
JeevaniChinthala Aug 23, 2024
6ed52d2
lint issue-fix
JeevaniChinthala Aug 23, 2024
973ed6c
fix e2e test failures
v-rakeshsh Aug 26, 2024
fe6c22b
PR comments & e2e test snap update
v-prachin Aug 26, 2024
f3d8084
Build error fix
v-prachin Aug 26, 2024
d3da3e6
Changes for PR check errors
v-prachin Aug 27, 2024
b2e8510
fixing focus issues
v-rakeshsh Aug 28, 2024
9d6f6c9
fixing focus issues
v-rakeshsh Aug 28, 2024
2f8e72e
fixing focus issues
v-rakeshsh Aug 28, 2024
0d922b7
fix build issues
v-rakeshsh Aug 28, 2024
ee88b74
fix lint issues
v-rakeshsh Aug 28, 2024
14a8e0c
fix lint issues
v-rakeshsh Aug 28, 2024
1ac70f9
fix lint issues
v-rakeshsh Aug 28, 2024
9877185
retaining iButton
v-rakeshsh Aug 29, 2024
9463f5d
retaining iButton
v-rakeshsh Aug 29, 2024
9c83758
delete initState file
v-rakeshsh Aug 30, 2024
84e1794
small changes
v-rakeshsh Aug 30, 2024
968bf97
small changes
v-rakeshsh Aug 30, 2024
38346a6
small changes
v-rakeshsh Aug 30, 2024
d4982b0
chore: review comments fix
v-rakeshsh Sep 9, 2024
602348a
chore: review comments fix
v-rakeshsh Sep 9, 2024
0cb48d5
chore: review comments fix
v-rakeshsh Sep 9, 2024
6cef9a5
chore: review comments fix
v-rakeshsh Sep 10, 2024
acd5c20
chore: review comments fix
v-rakeshsh Sep 10, 2024
546e552
chore: review comments fix
v-rakeshsh Sep 10, 2024
6ece7cc
chore: review comments fix
v-rakeshsh Sep 11, 2024
392d084
chore: review comments fix
v-rakeshsh Sep 12, 2024
cbca978
chore: pipeline error fixx
v-rakeshsh Sep 12, 2024
03d1ba4
chore: test case refactoring
v-rakeshsh Sep 13, 2024
dfef144
chore: test case refactoring
v-rakeshsh Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions packages/report-e2e-tests/src/examples/axe-results-with-issues.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@
border: none;
display: flex;
align-items: baseline;
width: 100%;
width: auto;
}
.collapsible-container .collapsible-control:hover {
background-color: var(--neutral-alpha-4);
Expand Down Expand Up @@ -993,13 +993,27 @@
color: buttontext !important;
}
}
.kebab-menu-icon--EUIj-:hover {
border-style: solid !important;
border-width: 1px;
padding-left: 8px !important;
padding-right: 8px !important;
padding-top: 5px !important;
padding-bottom: 5px !important;
.fileissue--x5mek {
font-weight: 400 !important;
}
.fileissue--x5mek:hover > span > svg {
color: var(--insights-button-hover);
}
.fileissue--x5mek:focus {
outline: 1px solid;
}
.copyfailuredetails--NHZE4 {
font-weight: 400 !important;
}
.copyfailuredetails--NHZE4:hover > span > svg {
color: var(--insights-button-hover);
}
.menu-Button--ElHFS:hover {
border: 1px solid var(--primary-text) !important;
color: var(--primary-text) !important;
}
.menu-Button--ElHFS:focus {
outline: 1px solid;
}
.kebab-menu-button--9Qt0a {
margin-right: 8px;
Expand Down Expand Up @@ -1105,6 +1119,7 @@
display: flex;
align-items: baseline;
text-align: left;
font-weight: normal;
}
.rule-details-group--Tb-LW .rule-detail .outcome-chip {
vertical-align: middle;
Expand Down
31 changes: 23 additions & 8 deletions packages/report-e2e-tests/src/examples/axe-results-without-issues.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@
border: none;
display: flex;
align-items: baseline;
width: 100%;
width: auto;
}
.collapsible-container .collapsible-control:hover {
background-color: var(--neutral-alpha-4);
Expand Down Expand Up @@ -993,13 +993,27 @@
color: buttontext !important;
}
}
.kebab-menu-icon--EUIj-:hover {
border-style: solid !important;
border-width: 1px;
padding-left: 8px !important;
padding-right: 8px !important;
padding-top: 5px !important;
padding-bottom: 5px !important;
.fileissue--x5mek {
font-weight: 400 !important;
}
.fileissue--x5mek:hover > span > svg {
color: var(--insights-button-hover);
}
.fileissue--x5mek:focus {
outline: 1px solid;
}
.copyfailuredetails--NHZE4 {
font-weight: 400 !important;
}
.copyfailuredetails--NHZE4:hover > span > svg {
color: var(--insights-button-hover);
}
.menu-Button--ElHFS:hover {
border: 1px solid var(--primary-text) !important;
color: var(--primary-text) !important;
}
.menu-Button--ElHFS:focus {
outline: 1px solid;
}
.kebab-menu-button--9Qt0a {
margin-right: 8px;
Expand Down Expand Up @@ -1105,6 +1119,7 @@
display: flex;
align-items: baseline;
text-align: left;
font-weight: normal;
}
.rule-details-group--Tb-LW .rule-detail .outcome-chip {
vertical-align: middle;
Expand Down
31 changes: 23 additions & 8 deletions packages/report-e2e-tests/src/examples/combined-results-with-baseline-aware-issues.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@
border: none;
display: flex;
align-items: baseline;
width: 100%;
width: auto;
}
.collapsible-container .collapsible-control:hover {
background-color: var(--neutral-alpha-4);
Expand Down Expand Up @@ -993,13 +993,27 @@
color: buttontext !important;
}
}
.kebab-menu-icon--EUIj-:hover {
border-style: solid !important;
border-width: 1px;
padding-left: 8px !important;
padding-right: 8px !important;
padding-top: 5px !important;
padding-bottom: 5px !important;
.fileissue--x5mek {
font-weight: 400 !important;
}
.fileissue--x5mek:hover > span > svg {
color: var(--insights-button-hover);
}
.fileissue--x5mek:focus {
outline: 1px solid;
}
.copyfailuredetails--NHZE4 {
font-weight: 400 !important;
}
.copyfailuredetails--NHZE4:hover > span > svg {
color: var(--insights-button-hover);
}
.menu-Button--ElHFS:hover {
border: 1px solid var(--primary-text) !important;
color: var(--primary-text) !important;
}
.menu-Button--ElHFS:focus {
outline: 1px solid;
}
.kebab-menu-button--9Qt0a {
margin-right: 8px;
Expand Down Expand Up @@ -1105,6 +1119,7 @@
display: flex;
align-items: baseline;
text-align: left;
font-weight: normal;
}
.rule-details-group--Tb-LW .rule-detail .outcome-chip {
vertical-align: middle;
Expand Down
31 changes: 23 additions & 8 deletions packages/report-e2e-tests/src/examples/combined-results-with-issues.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@
border: none;
display: flex;
align-items: baseline;
width: 100%;
width: auto;
}
.collapsible-container .collapsible-control:hover {
background-color: var(--neutral-alpha-4);
Expand Down Expand Up @@ -993,13 +993,27 @@
color: buttontext !important;
}
}
.kebab-menu-icon--EUIj-:hover {
border-style: solid !important;
border-width: 1px;
padding-left: 8px !important;
padding-right: 8px !important;
padding-top: 5px !important;
padding-bottom: 5px !important;
.fileissue--x5mek {
font-weight: 400 !important;
}
.fileissue--x5mek:hover > span > svg {
color: var(--insights-button-hover);
}
.fileissue--x5mek:focus {
outline: 1px solid;
}
.copyfailuredetails--NHZE4 {
font-weight: 400 !important;
}
.copyfailuredetails--NHZE4:hover > span > svg {
color: var(--insights-button-hover);
}
.menu-Button--ElHFS:hover {
border: 1px solid var(--primary-text) !important;
color: var(--primary-text) !important;
}
.menu-Button--ElHFS:focus {
outline: 1px solid;
}
.kebab-menu-button--9Qt0a {
margin-right: 8px;
Expand Down Expand Up @@ -1105,6 +1119,7 @@
display: flex;
align-items: baseline;
text-align: left;
font-weight: normal;
}
.rule-details-group--Tb-LW .rule-detail .outcome-chip {
vertical-align: middle;
Expand Down
31 changes: 23 additions & 8 deletions packages/report-e2e-tests/src/examples/combined-results-without-issues.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@
border: none;
display: flex;
align-items: baseline;
width: 100%;
width: auto;
}
.collapsible-container .collapsible-control:hover {
background-color: var(--neutral-alpha-4);
Expand Down Expand Up @@ -993,13 +993,27 @@
color: buttontext !important;
}
}
.kebab-menu-icon--EUIj-:hover {
border-style: solid !important;
border-width: 1px;
padding-left: 8px !important;
padding-right: 8px !important;
padding-top: 5px !important;
padding-bottom: 5px !important;
.fileissue--x5mek {
font-weight: 400 !important;
}
.fileissue--x5mek:hover > span > svg {
color: var(--insights-button-hover);
}
.fileissue--x5mek:focus {
outline: 1px solid;
}
.copyfailuredetails--NHZE4 {
font-weight: 400 !important;
}
.copyfailuredetails--NHZE4:hover > span > svg {
color: var(--insights-button-hover);
}
.menu-Button--ElHFS:hover {
border: 1px solid var(--primary-text) !important;
color: var(--primary-text) !important;
}
.menu-Button--ElHFS:focus {
outline: 1px solid;
}
.kebab-menu-button--9Qt0a {
margin-right: 8px;
Expand Down Expand Up @@ -1105,6 +1119,7 @@
display: flex;
align-items: baseline;
text-align: left;
font-weight: normal;
}
.rule-details-group--Tb-LW .rule-detail .outcome-chip {
vertical-align: middle;
Expand Down
31 changes: 23 additions & 8 deletions packages/report-e2e-tests/src/examples/summary-scan-with-issues.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@
border: none;
display: flex;
align-items: baseline;
width: 100%;
width: auto;
}
.collapsible-container .collapsible-control:hover {
background-color: var(--neutral-alpha-4);
Expand Down Expand Up @@ -993,13 +993,27 @@
color: buttontext !important;
}
}
.kebab-menu-icon--EUIj-:hover {
border-style: solid !important;
border-width: 1px;
padding-left: 8px !important;
padding-right: 8px !important;
padding-top: 5px !important;
padding-bottom: 5px !important;
.fileissue--x5mek {
font-weight: 400 !important;
}
.fileissue--x5mek:hover > span > svg {
color: var(--insights-button-hover);
}
.fileissue--x5mek:focus {
outline: 1px solid;
}
.copyfailuredetails--NHZE4 {
font-weight: 400 !important;
}
.copyfailuredetails--NHZE4:hover > span > svg {
color: var(--insights-button-hover);
}
.menu-Button--ElHFS:hover {
border: 1px solid var(--primary-text) !important;
color: var(--primary-text) !important;
}
.menu-Button--ElHFS:focus {
outline: 1px solid;
}
.kebab-menu-button--9Qt0a {
margin-right: 8px;
Expand Down Expand Up @@ -1105,6 +1119,7 @@
display: flex;
align-items: baseline;
text-align: left;
font-weight: normal;
}
.rule-details-group--Tb-LW .rule-detail .outcome-chip {
vertical-align: middle;
Expand Down
31 changes: 23 additions & 8 deletions packages/report-e2e-tests/src/examples/summary-scan-without-issues.snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@
border: none;
display: flex;
align-items: baseline;
width: 100%;
width: auto;
}
.collapsible-container .collapsible-control:hover {
background-color: var(--neutral-alpha-4);
Expand Down Expand Up @@ -993,13 +993,27 @@
color: buttontext !important;
}
}
.kebab-menu-icon--EUIj-:hover {
border-style: solid !important;
border-width: 1px;
padding-left: 8px !important;
padding-right: 8px !important;
padding-top: 5px !important;
padding-bottom: 5px !important;
.fileissue--x5mek {
font-weight: 400 !important;
}
.fileissue--x5mek:hover > span > svg {
color: var(--insights-button-hover);
}
.fileissue--x5mek:focus {
outline: 1px solid;
}
.copyfailuredetails--NHZE4 {
font-weight: 400 !important;
}
.copyfailuredetails--NHZE4:hover > span > svg {
color: var(--insights-button-hover);
}
.menu-Button--ElHFS:hover {
border: 1px solid var(--primary-text) !important;
color: var(--primary-text) !important;
}
.menu-Button--ElHFS:focus {
outline: 1px solid;
}
.kebab-menu-button--9Qt0a {
margin-right: 8px;
Expand Down Expand Up @@ -1105,6 +1119,7 @@
display: flex;
align-items: baseline;
text-align: left;
font-weight: normal;
}
.rule-details-group--Tb-LW .rule-detail .outcome-chip {
vertical-align: middle;
Expand Down
5 changes: 4 additions & 1 deletion src/DetailsView/components/assessment-instance-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { IRenderFunction } from '@fluentui/utilities';
import { AssessmentDefaultMessageGenerator } from 'assessments/assessment-default-message-generator';
import { InstanceTableHeaderType, InstanceTableRow } from 'assessments/types/instance-table-data';
import { InsightsCommandButton } from 'common/components/controls/insights-command-button';
import { FluentUIV9Icon } from 'common/icons/fluentui-v9-icons';
import { ManualTestStatus } from 'common/types/store-data/manual-test-status';
import { hasIn } from 'lodash';
import * as React from 'react';
Expand Down Expand Up @@ -125,7 +126,9 @@ export class AssessmentInstanceTable extends React.Component<AssessmentInstanceT
return (
<InsightsCommandButton
data-automation-id={passUnmarkedInstancesButtonAutomationId}
iconProps={{ iconName: 'skypeCheck' }}
insightsCommandButtonIconProps={{
icon: <FluentUIV9Icon iconName="Checkmark20Filled" />,
}}
onClick={this.onPassUnmarkedInstances}
disabled={disabled}
>
Expand Down
Loading
Loading