-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fluentUI-migration): ActionButton fluentui v8 to v9 migration #7401
feat(fluentUI-migration): ActionButton fluentui v8 to v9 migration #7401
Conversation
…osoft/accessibility-insights-web into v-rakesh/actionbutton-migration
…es, format & lint fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge effort, well done! I have some questions about things I was confused about and didn't see obvious explanations for.
src/tests/unit/tests/DetailsView/components/details-view-command-bar.test.tsx
Outdated
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/failure-instance-panel-control.test.tsx
Outdated
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx
Outdated
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/save-assessment-dialog.test.tsx
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/start-over-dropdown.test.tsx
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/tests/unit/tests/DetailsView/components/__snapshots__/save-assessment-dialog.test.tsx.snap
Outdated
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx
Outdated
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/save-assessment-button.test.tsx
Show resolved
Hide resolved
Hi @madalynrose i have checked this issue on Prod version, its reproducible in prod version as well. Please suggest. |
Let's make a separate issue for it and it doesn't need to be fixed in this particular PR. |
src/tests/unit/tests/DetailsView/components/save-assessment-dialog.test.tsx
Show resolved
Hide resolved
src/tests/unit/tests/DetailsView/components/save-assessment-dialog.test.tsx
Outdated
Show resolved
Hide resolved
15a87c1
into
fluent-ui-v9-migration-main
Details
Action Button migration from V8 to V9
Styling Improvements:
100%
toauto
for better layout flexibility in multiple snapshot files.normal
for better text consistency.Component Enhancements:
FluentUIV9Icon
import and updated the components to use the new icon.Motivation
Context
UI locations for all the files are mentioned with images in below file:
ActionButtonComparison
Due to FluentUI V9 Migration there are slight differences between old and new Icons. PFA screenshots below.
Note :
Please refer for more information on the error:[Bug]: Tablist - ARIA hidden element must not be focusable or contain focusable elements fluentui#25133
Technical Debt:
These will be take care in up coming PR for v8 to v9 migration.
IButton:
Card footer button scroll behaviour
Closing dialog focus issue
Focus style inconsistency
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.