Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remove-android): Remove mock-adb #6745

Merged
merged 7 commits into from
Jun 22, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,8 @@ jobs:
timeout-minutes: 2
with:
trap-caching: false
languages: javascript
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeql is expecting to build JavaScript and C#, and complaining when the C# portion is not found. Explicitly telling codeql that we're building JavaScript sets the correct expectation.


- uses: github/codeql-action/autobuild@v2
Copy link
Contributor Author

@DaveTryon DaveTryon Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github/codeql-action/autobuild@v2 step was added in #5737, and was needed for the C# code in mock-adb. Now that we're back to just JavaScript, we don't need it.

timeout-minutes: 2

- uses: github/codeql-action/analyze@v2
timeout-minutes: 10

Expand Down
23 changes: 0 additions & 23 deletions packages/mock-adb/MockAdb.csproj

This file was deleted.

45 changes: 0 additions & 45 deletions packages/mock-adb/README.md

This file was deleted.

37 changes: 0 additions & 37 deletions packages/mock-adb/src/CommandResult.cs

This file was deleted.

70 changes: 0 additions & 70 deletions packages/mock-adb/src/Program.cs

This file was deleted.

10 changes: 0 additions & 10 deletions src/tests/miscellaneous/setup-mock-adb/README.md

This file was deleted.

5 changes: 0 additions & 5 deletions src/tests/miscellaneous/setup-mock-adb/assets/config.json

This file was deleted.

Loading