feat(remove-android): Remove mock-adb #6745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
commented
Jun 22, 2023
|
|
||
| - uses: github/codeql-action/autobuild@v2 |
There was a problem hiding this comment.
The github/codeql-action/autobuild@v2 step was added in #5737, and was needed for the C# code in mock-adb. Now that we're back to just JavaScript, we don't need it.
DaveTryon
commented
Jun 22, 2023
| @@ -157,10 +157,8 @@ jobs: | |||
| timeout-minutes: 2 | |||
| with: | |||
| trap-caching: false | |||
| languages: javascript | |||
There was a problem hiding this comment.
codeql is expecting to build JavaScript and C#, and complaining when the C# portion is not found. Explicitly telling codeql that we're building JavaScript sets the correct expectation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Deprecating Android support will touch hundreds of files, so we're breaking it up into more manageable units. This PR removes the files to build and configure mock-adb. Later PR's will remove the .NET build tools and the code that was added to enable e2e tests to force the code to start the session with an empty setup store.
Motivation
Android deprecation feature
Context
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.