Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added KeyUsage DigitalSignature to CA certs. #197

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Added KeyUsage DigitalSignature to CA certs. #197

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3b810d
Added KeyUsage `DigitalSignature` to CA certs.
bkstein May 12, 2022
2ae66e4
Merge remote-tracking branch 'origin' into kletterstein/cacert-keyusage
bkstein Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ SCEPSERVER=\

my: scepclient-$(OSARCH) scepserver-$(OSARCH)

win: scepclient-$(OSARCH).exe scepserver-$(OSARCH).exe

docker: scepclient-linux-amd64 scepserver-linux-amd64

$(SCEPCLIENT):
Expand Down Expand Up @@ -48,4 +50,4 @@ test:
test-race:
go test -cover -race ./...

.PHONY: my docker $(SCEPCLIENT) $(SCEPSERVER) release clean test test-race
.PHONY: my mywin docker $(SCEPCLIENT) $(SCEPSERVER) release clean test test-race
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Binary releases are available on the [releases page](https://github.com/micromdm
To compile the SCEP client and server you will need [a Go compiler](https://golang.org/dl/) as well as standard tools like git, make, etc.

1. Clone the repository and get into the source directory: `git clone https://github.com/micromdm/scep.git && cd scep`
2. Compile the client and server binaries: `make`
2. Compile the client and server binaries: `make` (for Windows: `make win`)

The binaries will be compiled in the current directory and named after the architecture. I.e. `scepclient-linux-amd64` and `scepserver-linux-amd64`.

Expand Down
4 changes: 3 additions & 1 deletion depot/cacert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ func NewCACert(opts ...CACertOption) *CACert {
organization: "scep-ca",
organizationalUnit: "SCEP CA",
years: 10,
keyUsage: x509.KeyUsageCertSign | x509.KeyUsageCRLSign,
keyUsage: x509.KeyUsageCertSign |
x509.KeyUsageCRLSign |
x509.KeyUsageDigitalSignature,
}
for _, opt := range opts {
opt(c)
Expand Down