Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added KeyUsage DigitalSignature to CA certs. #197

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

bkstein
Copy link
Contributor

@bkstein bkstein commented May 12, 2022

DigitalSignature MUST be set in SCEP CA certificates according to RFC 8894:

2.1.2. Certificate Authority

A SCEP CA is the entity that signs client certificates. A CA may
enforce policies and apply them to certificate requests, and it may
reject a request for any reason.

Since the client is expected to perform signature verification and
optionally encryption using the CA certificate, the keyUsage
extension in the CA certificate MUST indicate that it is valid for
digitalSignature
and keyEncipherment (if the key is to be used for
en/decryption) alongside the usual CA usages of keyCertSign and/or
cRLSign.

This is also what I see in other SCEP CAs (e.g. LANCOM, EJBCA). It makes sense, as the PKCS7 replies are signed by the CA and the KeyCertSign KeyUsage is not meant for this (thats only for the included new certificate).

@bkstein
Copy link
Contributor Author

bkstein commented May 16, 2022

Added the RFC paragraph mentioning the keyUsage for SCEP CA certificates.

Copy link
Member

@jessepeterson jessepeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the (very late!) delay on this. Would you be willing to rebase this PR? You can drop the Makefile mods since they . If not, no worries — I can add the keyUsage separately. Cheers, thanks and sorry again.

@bkstein
Copy link
Contributor Author

bkstein commented Dec 1, 2023

Updated to current main. Merging should be possible now. Thanks!

@jessepeterson jessepeterson merged commit aa863fe into micromdm:main Dec 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants