Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Update Runtime to work with Berkeley schema (meta PR) #581

Closed
wants to merge 102 commits into from

Conversation

eecavanna
Copy link
Collaborator

I am creating this PR so that people can opt into receiving notifications whenever something gets merged into the berkeley branch.

eecavanna and others added 3 commits July 8, 2024 18:38
…reventing-runtime-from-booting-with-berkeley-schema

Switch to "Berkeley schema" and eliminate broken references preventing application startup
@eecavanna eecavanna self-assigned this Jul 9, 2024
@eecavanna eecavanna linked an issue Jul 9, 2024 that may be closed by this pull request
38 tasks
eecavanna and others added 25 commits July 9, 2024 15:48
`berkeley`: Merge `main` into `berkeley` (to trigger GHA workflow)
Updating to a berkeley schema valid biosample json file
Add type to DataObject.
Added missing comma for DataObject example
…berkeley-20240717

Merge `main` into `berkeley` (July 17)
…lid-biosample

`berkeley`: Update `test_endpoints.py` to fix some failing tests
…r-to-use-first-typecode-when-pattern-contains-multiple-typecodes

Update minter to use first typecode when pattern contains multiple typecodes
…le-merging-main-into-berkeley

Merge `main` into `berkeley` (routine merge on August 9, 2024)
…ime (#634)

* Documentation expectations regarding merging `main` into `berkeley`

* Fix typo

* Clarify expectation

* Clarify sentence

* Fix typo
…#637)

* Get ORCID base URL (production vs. sandbox) from environment variable

* style: reformat

---------

Co-authored-by: github-actions <[email protected]>
…ctionary-is-not-compatible-with-orcid-sandbox-environment

Use ORCID environment-specific JWKS values and clean up existing comments
* Update test_gold_translator.py to add `type`

* Update test_gold_translator.py

remove extra bracket

* Update test_gold_translator.py

syntax fixes

* chore: format

* fix: pass `type` to constructor

closes #600

* fix: make test idempotent

* feat: more resilient test data loading

* fix: failing `test_get_samp_taxon_id`

* fix: `test_get_collection_date` requires timestampvalue type

* fix: add type to _get_quantity_value for gold & submission portal translators

* fix:_get_text_value

* update:test_get_controlled_term_value with comment

* fix:test_get_lat_lon types

* add types to _get_env_term_value

* add types to submission portal translator

* fix:broken neon translator tests

* add types for submission portal translator

* update doi getter

* feat: clear test dbs on `make down-test`

* fix: `test_get_doi`

* fix: partial fix for `test_get_dataset`

* add types to test data yaml

* add more types

* add credit assoc

* add person, study

* add type for env_package

* add types for mock submission object

* add types to translator

* skip three remaining failing tests

---------

Co-authored-by: Donny Winston <[email protected]>
Co-authored-by: Jing <[email protected]>
* update /workflows/activities to /workflows/workflow_executions

* modify test submit workflow executions

* remove api/v1/workflows dir

* remove unused files in `api/v1`

* formatting

* update  endpoints

* feat: refactor find endpoints

* feat: reproduce deprecated interface and use `deprectated` kwarg

* chore: docstring update

* fix: `find_workflow_execution_by_id`

add tests for /workflow_executions/* endpoints

* fix: unskip `test_submit_workflow_executions`

---------

Co-authored-by: Jing <[email protected]>
Co-authored-by: Donny Winston <[email protected]>
Merge `main` into `berkeley` (routine, August 23, 2024)
aclum and others added 28 commits September 18, 2024 11:19
commenting out pytest skip
Updating test_submit_workflow_activities
update POST endpoint for workflows
…682-documentation-updates-for-berkeley

Restore hyperlinks to "Metadata" section and modernize Runtime description
…activities

`berkeley`: Unskip `test_submit_workflow_activities` test and make it work with Berkeley schema
…iles-are-being-skipped-by-mistake

`berkeley`: Restore tests that were being skipped by mistake (oops)
…st_gold_api_ops

Quick fixes for GOLD API client tests in `tests/test_ops/test_gold_api_ops.py`
Merge `main` into `berkeley` (routine, September 19, 2024)
The previous code made the invalid assumption that a given collection
could only store documents of a single type. That constraint does not
exist in databases conforming to the Berkeley schema (nmdc-schema v11+).
…integrity-notebook

576 berkeley updates ref integrity notebook
…-ensure_alldocs-fails-with-assertionerror-1

`berkeley`: Determine class ancestry per-type value (within collection) instead of per-collection (when generating `alldocs`)
…-data_objectsstudystudy_id-not-returning-correct-results

Update field name to be consistent with Berkeley schema
@eecavanna
Copy link
Collaborator Author

I am closing this draft PR in order to see what effect closing it has on the symptoms described in issue #700.

@eecavanna eecavanna closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Runtime to work with the Berkeley schema (meta issue) 📚
6 participants