Add int32_publisher_custom_transport_usbcdc example #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pablogs9 could you review my PR? I would like to contribute this example |
|
Hello @SamuelLost, thanks for the contribution but I have no time to test it. Could you somehow add it to the CI so we can ensure it builds correctly? |
SamuelLost
force-pushed
the
feature/usbcdc_transport
branch
from
53284df
to
294bca3
Compare
This example demonstrates how to enable ROS2 communication via USB CDC and log output on the ESP32-S2. Reviewed-by: Leandro Mendes do Santos <[email protected]> Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]>
SamuelLost
force-pushed
the
feature/usbcdc_transport
branch
from
294bca3
to
d9d6135
Compare
Hello, thanks for the feedback! I'll try to add it to the CI to ensure it builds correctly. |
…CI workflow Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]>
|
It seems that the new example is failing in CI |
- Updated conditional logic to ensure builds are triggered only when idf_target is either 'esp32s2' or 'esp32s3' and idf_version is 'espressif/idf:release-v5.2'. Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]>
|
The issue was with the CI condition, I made the necessary adjustment and hopefully it won't fail this time. |
|
@mergify backport rolling humble iron |
✅ Backports have been created
|
|
@SamuelLost Thanks for the contribution! |
mergify bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Add int32_publisher_custom_transport_usbcdc example This example demonstrates how to enable ROS2 communication via USB CDC and log output on the ESP32-S2. Reviewed-by: Leandro Mendes do Santos <[email protected]> Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> * Add build for int32_publisher_custom_transport_usbcdc example to the CI workflow Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> * Fix CI condition for int32_publisher_custom_transport_usbcdc example - Updated conditional logic to ensure builds are triggered only when idf_target is either 'esp32s2' or 'esp32s3' and idf_version is 'espressif/idf:release-v5.2'. Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> --------- Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> (cherry picked from commit c2d581a)
mergify bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Add int32_publisher_custom_transport_usbcdc example This example demonstrates how to enable ROS2 communication via USB CDC and log output on the ESP32-S2. Reviewed-by: Leandro Mendes do Santos <[email protected]> Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> * Add build for int32_publisher_custom_transport_usbcdc example to the CI workflow Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> * Fix CI condition for int32_publisher_custom_transport_usbcdc example - Updated conditional logic to ensure builds are triggered only when idf_target is either 'esp32s2' or 'esp32s3' and idf_version is 'espressif/idf:release-v5.2'. Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> --------- Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> (cherry picked from commit c2d581a)
mergify bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Add int32_publisher_custom_transport_usbcdc example This example demonstrates how to enable ROS2 communication via USB CDC and log output on the ESP32-S2. Reviewed-by: Leandro Mendes do Santos <[email protected]> Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> * Add build for int32_publisher_custom_transport_usbcdc example to the CI workflow Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> * Fix CI condition for int32_publisher_custom_transport_usbcdc example - Updated conditional logic to ensure builds are triggered only when idf_target is either 'esp32s2' or 'esp32s3' and idf_version is 'espressif/idf:release-v5.2'. Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> --------- Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> (cherry picked from commit c2d581a)
This was referenced Oct 2, 2024
pablogs9
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Add int32_publisher_custom_transport_usbcdc example This example demonstrates how to enable ROS2 communication via USB CDC and log output on the ESP32-S2. Reviewed-by: Leandro Mendes do Santos <[email protected]> Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> * Add build for int32_publisher_custom_transport_usbcdc example to the CI workflow Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> * Fix CI condition for int32_publisher_custom_transport_usbcdc example - Updated conditional logic to ensure builds are triggered only when idf_target is either 'esp32s2' or 'esp32s3' and idf_version is 'espressif/idf:release-v5.2'. Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> --------- Signed-off-by: Samuel Henrique Guimarães Alencar <[email protected]> (cherry picked from commit c2d581a) Co-authored-by: Samuel Henrique <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example demonstrates how to enable ROS2 communication via USB CDC and log output on the ESP32-S2.