Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name of cubes from gradient module #2045

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mspelman07
Copy link
Contributor

@mspelman07 mspelman07 commented Oct 30, 2024

EPP ticket: https://metoffice.atlassian.net/browse/EPPT-1826
Acceptance_test_data: metoppv/improver_test_data#60

Updates the name of output cubes from the gradient-between-adjacent-modules so that the two output cubes can be distinguished.

Testing:

  • Ran tests and they passed OK

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (84a8944) to head (a8b406c).
Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2045      +/-   ##
==========================================
- Coverage   98.39%   98.38%   -0.01%     
==========================================
  Files         124      133       +9     
  Lines       12212    13017     +805     
==========================================
+ Hits        12016    12807     +791     
- Misses        196      210      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mspelman07 mspelman07 added the EPP PR's related to Enhancing Post Processing team label Oct 30, 2024
Copy link

@seshukolusu16 seshukolusu16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with changes.

Copy link
Contributor

@Katie-Howard Katie-Howard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked through this and it all looks fine to me :) I've run the unit and acceptance tests using the new acceptance test data and they all pass too. So I'm happy with this 👍

The only problem is that apparently not all the checks run apparently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPP PR's related to Enhancing Post Processing team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants