Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update names of gradient-between-adjacent-grid-square cubes #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update names of gradient-between-adjacent-grid-square cubes #60

wants to merge 1 commit into from

Conversation

mspelman07
Copy link
Contributor

@mspelman07 mspelman07 commented Oct 30, 2024 •
edited
Loading

@mspelman07 mspelman07 mentioned this pull request Oct 30, 2024
Open
1 task
Katie-Howard
Katie-Howard approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@Katie-Howard Katie-Howard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked through the acceptance test data and I think this looks fine. It runs and passes the acceptance tests and the new kgo cubes have the new name e.g. gradient_of_grid_eastward_wind_wrt_y or gradient_of_grid_eastward_wind_wrt_x. So I'm happy these changes are fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katie-Howard Katie-Howard Katie-Howard approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mspelman07 @Katie-Howard