Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update comment #184

Merged
merged 12 commits into from
Aug 15, 2023
Merged

Fix/update comment #184

Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cd5f0a5
test syntax
rugeli Jul 27, 2023
13c6ec3
passed check
rugeli Jul 27, 2023
0c4ff2f
skip the entire job if isn't pr
rugeli Jul 27, 2023
d4333b9
test GITHUB_OUTPUT
rugeli Jul 28, 2023
9227cde
test analyze in comment
rugeli Jul 28, 2023
c175a26
passed checks, ready for review
rugeli Jul 28, 2023
1f13208
testing: run on pull_request
rugeli Aug 2, 2023
8f72bcd
run when pushed into main
rugeli Aug 2, 2023
207286f
test on draft pr
rugeli Aug 2, 2023
8002c93
changed name back to analyze
rugeli Aug 2, 2023
56afd96
remove default PR types for simplicity
rugeli Aug 2, 2023
7effeae
Merge branch 'main' of https://github.com/mesoscope/cellpack into fix…
rugeli Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/analyze.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,24 @@ name: Analyze
on: push

jobs:
Check_pr:
runs-on: ubuntu-latest
outputs:
is_pr: ${{ steps.check.outputs.is_pr }}
steps:
- name: Check if PR
id: check
run: |
if [[ "${{ github.event.pull_request }}" != "" ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like github.event.pull_request is empty for this PR, which results in this statement evaluating to False. Maybe test it by checking what is the value stored in github.event.pull_request?

echo "is_pr=true" >> $GITHUB_OUTPUT
else
echo "is_pr=false" >> $GITHUB_OUTPUT
echo "Not a PR, skipping analysis"
fi
Analyze:
runs-on: ${{ matrix.os }}
needs: [Check_pr]
if: needs.Check_pr.outputs.is_pr == 'true'
strategy:
matrix:
python-version: [3.9]
Expand Down
Loading