Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update comment #184

Merged
merged 12 commits into from
Aug 15, 2023
Merged

Fix/update comment #184

merged 12 commits into from
Aug 15, 2023

Conversation

rugeli
Copy link
Collaborator

@rugeli rugeli commented Jul 27, 2023

Problem

What is the problem this work solves, including
#176

Solution

What I/we did to solve this problem
the workflow will on be triggered when:

  1. a commit merged into main
  2. a pull request has been opened/synchronized/reopened
Screenshot 2023-08-02 at 2 55 04 PM

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Steps to Verify:

  1. Push a commit on a branch that is not associated with a pull request---(the Analyze workflow will not be triggered)

@rugeli rugeli requested review from meganrm and mogres July 27, 2023 21:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d398510) 98.42% compared to head (56afd96) 98.42%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          15       15           
  Lines         444      444           
=======================================
  Hits          437      437           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mogres
Copy link
Collaborator

mogres commented Jul 27, 2023

This looks great! We could also skip the entire workflow (including the analysis part) if a PR does not exist. What do you think about moving the check further up in the .yml file? This will save us storage and processing time. Or do we want to keep the results on AWS as a test?

image

@rugeli
Copy link
Collaborator Author

rugeli commented Jul 27, 2023

This looks great! We could also skip the entire workflow (including the analysis part) if a PR does not exist. What do you think about moving the check further up in the .yml file? This will save us storage and processing time. Or do we want to keep the results on AWS as a test?

image

Good suggestion! If we don't have a strong need for keeping results from non-PR commits in AWS, then I'll go for saving storage and processing time.

@meganrm
Copy link
Member

meganrm commented Aug 2, 2023

Looks great, but I'm confused why this PR doesn't have the analyst and comment on it

- name: Check if PR
id: check
run: |
if [[ "${{ github.event.pull_request }}" != "" ]]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like github.event.pull_request is empty for this PR, which results in this statement evaluating to False. Maybe test it by checking what is the value stored in github.event.pull_request?

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@rugeli rugeli marked this pull request as draft August 2, 2023 21:44
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@rugeli rugeli marked this pull request as ready for review August 2, 2023 21:58
@mogres
Copy link
Collaborator

mogres commented Aug 2, 2023

Ran the following tests:

  1. Pushing a commit to a draft PR triggers the workflow
  2. Pushing a commit to a non-PR branch does not trigger the workflow
  3. Pushing a commit to an existing PR triggers the workflow
  4. Pushing multiple commits updates the existing comment

This is expected behavior and we should be good to merge!

Copy link
Member

@meganrm meganrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, wait for #185 to be merged.

@rugeli rugeli merged commit 8ab1881 into main Aug 15, 2023
7 checks passed
@rugeli rugeli deleted the fix/update-comment branch August 15, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants