Skip to content

Commit

Permalink
fix(mobile-resources-native): fix presentation style
Browse files Browse the repository at this point in the history
  • Loading branch information
UrazAkgultan committed Aug 16, 2023
1 parent cd0d870 commit 71a6c05
Show file tree
Hide file tree
Showing 4 changed files with 45 additions and 5 deletions.
36 changes: 35 additions & 1 deletion packages/jsActions/mobile-resources-native/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,113 +6,139 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Changed

- Minimum mx version set to 9.21.0
- We updated the default presentation mode for both "Take Picture" and "Take Picture Advanced" to full screen.

## [4.0.3] Native Mobile Resources - 2023-5-24

### Fixed

- We've updated react-native-device-info library.

## [3.2.2] BottomSheet

### Fixed

- We've updated react-native-device-info library.

## [1.0.2] Gallery

### Fixed

- We've updated react-native-device-info library.

## [3.2.3] IntroScreen

### Fixed

- We've updated react-native-device-info library.

## [4.0.2] Native Mobile Resources - 2023-5-17


## [3.0.1] BarChart

### Fixed

- We fixed an issue where height or width with a value of 0 crash the app.

## [2.0.1] ColumnChart

### Fixed

- We fixed an issue where height or width with a value of 0 crash the app.

## [3.0.1] LineChart

### Fixed

- We fixed an issue where height or width with a value of 0 crash the app.

## [2.0.1] PieDoughnutChart

### Fixed

- We fixed an issue where height or width with a value of 0 crash the app.

## [4.0.0] Native Mobile Resources - 2023-3-28

undefined

## [4.0.0] AppEvents

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [3.0.0] BarChart

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [4.0.0] BarcodeScanner

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [3.0.0] Carousel

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [2.0.0] ColorPicker

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [2.0.0] ColumnChart

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [4.0.0] FloatingActionButton

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [3.0.0] LineChart

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [3.0.0] ListViewSwipe

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [4.0.0] Maps

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [4.0.0] Notifications

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [2.0.0] PieDoughnutChart

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [3.0.0] PopupMenu

### Added

- Added id for testing
Expand All @@ -122,41 +148,49 @@ undefined
- We made the widget compatible with React Native 0.70.7

## [4.2.1] ProgressBar

### Changed

- Bumped react-native-progress dependency

## [3.1.1] ProgressCircle

### Changed

- Bumped react-native-progress dependency

## [3.0.0] Rating

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [2.0.0] Signature

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [3.0.0] Slider

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [4.0.0] VideoPlayer

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [4.0.0] WebView

## BREAKING

- We made the widget compatible with React Native 0.70.7

## [3.13.1] Native Mobile Resources - 2022-12-28

### Changed

- We reduced the widget file size by reducing the dependencies list file size.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export async function TakePicture(

function takePicture(): Promise<string | undefined> {
return new Promise((resolve, reject) => {
const options = nativeVersionMajor === 2 ? getOptionsV2() : getOptionsV4();
const options = nativeVersionMajor === 2 ? getOptionsV2() : getOptions();
getPictureMethod()
.then(method =>
method(options, (response: ImagePickerV2Response | ImagePickerResponse) => {
Expand Down Expand Up @@ -241,9 +241,10 @@ export async function TakePicture(
};
}

function getOptionsV4(): CameraOptions | ImageLibraryOptions {
function getOptions(): CameraOptions | ImageLibraryOptions {
const { maxWidth, maxHeight } = getPictureQuality();
return {
presentationStyle: "fullScreen",
mediaType: "photo" as const,
maxWidth,
maxHeight
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export async function TakePictureAdvanced(

function takePicture(): Promise<ImagePickerV2Response | ImagePickerResponse | undefined> {
return new Promise((resolve, reject) => {
const options = nativeVersionMajor === 2 ? getOptionsV2() : getOptionsV4();
const options = nativeVersionMajor === 2 ? getOptionsV2() : getOptions();
getPictureMethod()
.then(method =>
method(options, (response: ImagePickerV2Response | ImagePickerResponse) => {
Expand Down Expand Up @@ -294,9 +294,10 @@ export async function TakePictureAdvanced(
};
}

function getOptionsV4(): CameraOptions | ImageLibraryOptions {
function getOptions(): CameraOptions | ImageLibraryOptions {
const { maxWidth, maxHeight } = getPictureQuality();
return {
presentationStyle: "fullScreen",
mediaType: "photo" as const,
maxWidth,
maxHeight
Expand Down
4 changes: 4 additions & 0 deletions packages/jsActions/nanoflow-actions-native/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Changed

- Minimum mx version set to 9.21.0

## [2.6.1] Nanoflow Commons - 2022-9-23

### Fixed
Expand Down

0 comments on commit 71a6c05

Please sign in to comment.