Skip to content

Commit

Permalink
fix: fix native modules script, update min mx version
Browse files Browse the repository at this point in the history
  • Loading branch information
UrazAkgultan committed Aug 16, 2023
1 parent 19fcfc3 commit cd0d870
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions packages/jsActions/mobile-resources-native/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
"url": "https://github.com/mendix/native-widgets.git"
},
"marketplace": {
"minimumMXVersion": "9.24.0.2965",
"minimumMXVersion": "9.21.0.59661",
"marketplaceId": 109513
},
"testProject": {
"githubUrl": "https://github.com/mendix/native-mobile-resources",
"branchName": "main"
"branchName": "lts/mx/9.24"
},
"scripts": {
"prestart": "rimraf ./dist/tsc",
Expand Down Expand Up @@ -52,4 +52,4 @@
"rimraf": "^2.7.1",
"rollup": "^2.68.0"
}
}
}
4 changes: 2 additions & 2 deletions packages/jsActions/nanoflow-actions-native/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
"url": "https://github.com/mendix/native-widgets.git"
},
"marketplace": {
"minimumMXVersion": "9.24.0.2965",
"minimumMXVersion": "9.21.0.59661",
"marketplaceId": 109515
},
"testProject": {
"githubUrl": "https://github.com/mendix/native-mobile-resources",
"branchName": "main"
"branchName": "lts/mx/9.24"
},
"scripts": {
"start": "rollup --config ../../../configs/jsactions/rollup.config.js --watch --configProject nanoflowcommons",
Expand Down
4 changes: 2 additions & 2 deletions scripts/release/createNativeModules.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ async function updateNativeComponentsTestProject(moduleInfo, tmpFolder, nativeWi
const tmpFolderActions = join(tmpFolder, `javascriptsource/${moduleInfo.moduleFolderNameInModeler}/actions`);

console.log("Updating NativeComponentsTestProject...");
await cloneRepo(moduleInfo.testProjectUrl, tmpFolder);
await cloneRepo(moduleInfo.testProjectUrl, moduleInfo.testProjectBranchName, tmpFolder);

console.log("Deleting existing JS Actions from test project...");
await rm(tmpFolderActions, { force: true, recursive: true }); // this is useful to avoid retaining stale dependencies in the test project.
Expand Down Expand Up @@ -199,7 +199,7 @@ async function updateNativeComponentsTestProjectWithAtlas(moduleInfo, tmpFolder)
const tmpFolderNativeStyles = join(tmpFolder, `themesource/${moduleInfo.moduleFolderNameInModeler}`);

console.log("Updating NativeComponentsTestProject..");
await cloneRepo(moduleInfo.testProjectUrl, tmpFolder);
await cloneRepo(moduleInfo.testProjectUrl, moduleInfo.testProjectBranchName, tmpFolder);

console.log("Copying Native styling files..");
await Promise.all([
Expand Down
4 changes: 2 additions & 2 deletions scripts/release/module-automation/commons.js
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,12 @@ async function githubAuthentication(moduleInfo) {
await execShellCommand(`echo "${process.env.GH_PAT}" | gh auth login --with-token`);
}

async function cloneRepo(githubUrl, localFolder) {
async function cloneRepo(githubUrl, githubBranchName, localFolder) {
const githubUrlDomain = githubUrl.replace("https://", "");
const githubUrlAuthenticated = `https://${process.env.GH_USERNAME}:${process.env.GH_PAT}@${githubUrlDomain}`;
await rm(localFolder, { recursive: true, force: true });
await mkdir(localFolder, { recursive: true });
await execShellCommand(`git clone ${githubUrlAuthenticated} ${localFolder}`);
await execShellCommand(`git clone --branch ${githubBranchName} ${githubUrlAuthenticated} ${localFolder}`);
await setLocalGitCredentials(localFolder);
}

Expand Down

0 comments on commit cd0d870

Please sign in to comment.