Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fn BitDepth::pxstride: Make generic over stride type and BitDepth #769

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fn BitDepth::pxstride: Make generic over stride type and BitDepth #769

merged 2 commits into from
Feb 28, 2024

Commits on Feb 28, 2024

  1. fn BitDepth::pxstride: Implement generically over BitDepths.

    @kkysen
    kkysen committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8105376 View commit details
    Browse the repository at this point in the history

  2. fn BitDepth::pxstride: Implement generically over stride type, e.… 

    …x. `isize` or `usize`.

This way we don't have to do `BD::pxstride(stride as usize) as isize`,
which is verbose and wrong for negative strides.
There may still be some places where strides are always positive, though, so it's kept generic.
This also lets us fix #636 gradually; this is the first major step in fixing #636.
    @kkysen
    kkysen committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d7a51ce View commit details
    Browse the repository at this point in the history