fn BitDepth::pxstride: Make generic over stride type and BitDepth
#769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x. `isize` or `usize`. This way we don't have to do `BD::pxstride(stride as usize) as isize`, which is verbose and wrong for negative strides. There may still be some places where strides are always positive, though, so it's kept generic. This also lets us fix #636 gradually; this is the first major step in fixing #636.
Indeed, this should help. I will clean up the casts after this is merged. |
randomPoison
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we don't have to do
BD::pxstride(stride as usize) as isize, which is verbose and wrong for negative strides. There may still be some places where strides are always positive, though, so it's kept generic. This also lets us fix part of #636 gradually; this is the first major step in fixing part of #636. We'll fully fix that later.@fbossen, hopefully this'll help you in your PRs not have to write the hundreds of extra
as usize) as isizecasts.