Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#![allow(non_camel_case_types)]: Fix and remove #1302

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

kkysen
Copy link
Collaborator

@kkysen kkysen commented Jul 10, 2024

Supersedes #1301 by just fixing the warnings instead of papering over what appears to be a rust-analyzer false positive bug.

@kkysen kkysen requested a review from rinon July 10, 2024 20:47
@kkysen kkysen force-pushed the kkysen/fix-non_camel_case_types branch from 9309c62 to 740b44c Compare July 10, 2024 20:52
src/refmvs.rs Show resolved Hide resolved
@rinon rinon mentioned this pull request Jul 10, 2024
@kkysen kkysen force-pushed the kkysen/fix-non_camel_case_types branch from 740b44c to 6d3960d Compare July 10, 2024 22:10
`rust-analyzer` has false positives for this, so it's simpler to just fix it.
…`rustc` does not warn on, but `rust-analyzer` still does.
…k_stress` binaries (in shared `mod dav1d_cli_parse`, specifically).
@kkysen kkysen force-pushed the kkysen/fix-non_camel_case_types branch from 6d3960d to 7eda63d Compare July 10, 2024 22:12
@kkysen kkysen merged commit dbb9803 into main Jul 10, 2024
27 checks passed
@kkysen kkysen deleted the kkysen/fix-non_camel_case_types branch July 10, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants