Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix camel case warnings #1301

Closed
wants to merge 1 commit into from
Closed

Fix camel case warnings #1301

wants to merge 1 commit into from

Conversation

rinon
Copy link
Collaborator

@rinon rinon commented Jul 10, 2024

No description provided.

@rinon rinon requested a review from kkysen July 10, 2024 20:17
kkysen
kkysen requested changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed; we already have them in the root modules. I think it's a rust-analyzer bug.

tools/dav1d_cli_parse.rs
@@ -1,3 +1,5 @@
#![allow(non_camel_case_types)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this is dav1d.rs and seek_stress.rs already.

src/recon.rs
@@ -1,4 +1,5 @@
#![deny(unsafe_op_in_unsafe_fn)]
#![allow(non_camel_case_types)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this in lib.rs; it's not needed here. If you're seeing rust-analyzer warnings, that's a rust-analyzer issue. It got fixed last time we upgraded our nughtly but then it came back at some point, so I'm not sure what the underlying issue is.

@rinon
Copy link
Collaborator Author

rinon commented Jul 10, 2024

I'll check with stable, but is there any real reason not to just work around this? It's been super annoying for development.

@kkysen
Copy link
Collaborator

kkysen commented Jul 10, 2024

I'll check with stable, but is there any real reason not to just work around this? It's been super annoying for development.

Can I just make them camel case? That fixes it too and it's not very hard.

@kkysen
Copy link
Collaborator

kkysen commented Jul 10, 2024

It's been very annoying for me too

@kkysen kkysen mentioned this pull request Jul 10, 2024
Merged
@rinon
Copy link
Collaborator Author

rinon commented Jul 10, 2024

Closing in favor of #1302

@rinon rinon closed this Jul 10, 2024
kkysen added a commit that referenced this pull request Jul 10, 2024
@kkysen
#![allow(non_camel_case_types)]: Fix and remove (#1302)
dbb9803 
* Fixes `#![allow(non_camel_case_types)]` of #1299.

Supersedes #1301 by just fixing the warnings instead of papering over
what appears to be a `rust-analyzer` false positive bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkysen kkysen kkysen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rinon @kkysen