-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix camel case warnings #1301
Fix camel case warnings #1301
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed; we already have them in the root modules. I think it's a rust-analyzer bug.
@@ -1,3 +1,5 @@ | |||
#![allow(non_camel_case_types)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this is dav1d.rs
and seek_stress.rs
already.
@@ -1,4 +1,5 @@ | |||
#![deny(unsafe_op_in_unsafe_fn)] | |||
#![allow(non_camel_case_types)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have this in lib.rs
; it's not needed here. If you're seeing rust-analyzer
warnings, that's a rust-analyzer
issue. It got fixed last time we upgraded our nughtly
but then it came back at some point, so I'm not sure what the underlying issue is.
I'll check with stable, but is there any real reason not to just work around this? It's been super annoying for development. |
Can I just make them camel case? That fixes it too and it's not very hard. |
It's been very annoying for me too |
Closing in favor of #1302 |
No description provided.