fn cdef: Make safe
#1239
Merged
fn cdef: Make safe
#1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
requested changes
Jun 23, 2024
kkysen
added a commit
that referenced
this pull request
Jun 28, 2024
`rav1d_cdef_brow` is wrapped in TODO `unsafe` blocks since #1239 fixes that already (not merged yet).
kkysen
added a commit
that referenced
this pull request
Jun 29, 2024
`rav1d_cdef_brow` is wrapped in TODO `unsafe` blocks since #1239 fixes that already (not merged yet).
kkysen
added a commit
that referenced
this pull request
Jun 29, 2024
`rav1d_cdef_brow` is wrapped in TODO `unsafe` blocks since #1239 fixes that already (not merged yet).
kkysen
added a commit
that referenced
this pull request
Jun 29, 2024
`rav1d_cdef_brow` is wrapped in TODO `unsafe` blocks since #1239 fixes that already (not merged yet).
kkysen
added a commit
that referenced
this pull request
Jul 1, 2024
`rav1d_cdef_brow` is wrapped in TODO `unsafe` blocks since #1239 fixes that already (not merged yet).
|
Wait how did 093a17d close this PR? |
"Resolve" is a keyword to trigger closing a PR. |
kkysen
added a commit
that referenced
this pull request
Jul 1, 2024
* Fixes #848. * Fixes #855. * Fixes #841. This does add back some bounds checks since the only and final slicing is done in `fn loopfilter_sb::Fn::call`, which is inside inner loops. @fbossen, how does this look for perf? Only 2 `unsafe` ops left (after #1239 is merged, too)! Though still 122 `unsafe` ops in `neon` `fn`s. ## Addendum So it turns out the `- b4strideb` in `fn loop_filter_sb128_rust` makes the index negative, so the initial slice needs to be larger. This is difficult to safely do, though, because all of the other uses of `f.lf.level` do not go through `DisjointMut`'s safe APIs since there were overlapping `&mut`s since indices 0 and 1 are written simultaneously to 2 and 3, and thus were done `unsafe`ly. This loses the disjointedness checking, though, which is a problem for making other changes. Thus, this PR leaves the `- b4strideb` as an `unsafe` `lvl.as_ptr().sub(b4strideb)` for now. In a follow-up PR, I'm going to change the `[u8; 4]` `lvl` elements to just `u8`s. This will allow the disjoint writes to `[0..2]` and `[2..4]` to be done safely with `DisjointMut`s APIs and will remove the need for `fn unaligned_lvl_slice`. Fixed in #1273 now.
kkysen
added a commit
that referenced
this pull request
Jul 1, 2024
Including #1239, this is the last of non-`neon` `unsafe` ops.
Ugh, but I only linked a comment on a PR, not the PR itself. GitHub should be smarter. |
kkysen
added a commit
that referenced
this pull request
Jul 7, 2024
Assuming #1239 is already merged, this removes the last of `unsafe` ops when compiling for `target_arch = "arm"`. Now only `target_arch = "aarch64"` remains with 110 `unsafe` ops in `mod looprestoration::neon` (`x86`, `x86_64` are already done).
|
@kkysen I've reworked this to use |
kkysen
requested changes
Jul 9, 2024
kkysen
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the remaining Rust fallback in
cdef.rssafe by passing in additional arguments.cdef.rs: Unsafe cleanup #850.cdef_apply.rs: Unsafe cleanup #851.