fn resize: Make safe w/ WithOffset<PicOrBuf<AlignedVec64<u8>>>
#1268
Conversation
| let dst = match dst.data { | ||
| PicOrBuf::Pic(pic) => &mut *pic.slice_mut::<BD, _>((dst.offset.., ..dst_w)), | ||
| PicOrBuf::Buf(buf) => &mut *buf.mut_slice_as((dst.offset.., ..dst_w)), | ||
| }; |
There was a problem hiding this comment.
Would it make sense to move this logic into a slice_mut method on PicOrBuf? I expect that this pattern of matching on the enum and then doing the same slice operation on each variant would be a common usage of this type. If you don't add it in this PR I'd likely end up doing so in #1239.
There was a problem hiding this comment.
No, because this uses lifetime extension and the guard types are not the same, only the lifetime extended slices from dereferencing the guards. Lifetime extension doesn't work through functions, so only a macro would work here, and I don't think that's worth it (Maybe it could? What do you think? Postfix macros would be nice here.). I tried a while to get this kind of thing to work until I realized that I'm pretty sure it's impossible. I guess a closure could also work, but that's unwieldy.
There was a problem hiding this comment.
Nah, I didn't catch that this was doing lifetime extension and that we had different guard types. So doing the match locally makes sense, I don't think a macro is worth it here
kkysen
force-pushed
the
kkysen/fn-resize-safe
branch
from
75bd562
to
dc2898c
Compare
mc.rs: Unsafe cleanup #842.This pattern can also be used in #1239 and can be used to resolve #1239 (comment).